Skip to content

etcd-manager: Use image volumes to mount etcd images #17539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 10, 2025
Merged

etcd-manager: Use image volumes to mount etcd images #17539

merged 2 commits into from
Aug 10, 2025
+273 −424

Conversation

hakman
Copy link
Member

@hakman hakman commented Aug 3, 2025 •
edited
Loading

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot requested a review from justinsb August 3, 2025 13:56
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2025
@k8s-ci-robot k8s-ci-robot requested a review from rifelpet August 3, 2025 13:56
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 3, 2025
@hakman hakman mentioned this pull request Aug 3, 2025
Merged
@hakman hakman force-pushed the etcd-manager-image-volumes branch from be5982d to 68520e5 Compare August 3, 2025 16:12
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 3, 2025
@hakman hakman force-pushed the etcd-manager-image-volumes branch 2 times, most recently from e6a3edd to 4faa3c7 Compare August 5, 2025 05:56
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 5, 2025
@hakman
Copy link
Member Author

hakman commented Aug 5, 2025

/test pull-kops-e2e-k8s-aws-calico
/test pull-kops-e2e-k8s-gce-ipalias

@hakman hakman force-pushed the etcd-manager-image-volumes branch 2 times, most recently from c793a2d to 98273f3 Compare August 5, 2025 06:38
@hakman
Copy link
Member Author

hakman commented Aug 5, 2025

/test pull-kops-e2e-k8s-aws-calico
/test pull-kops-e2e-k8s-gce-cilium
/test pull-kops-e2e-k8s-gce-ipalias

@hakman hakman force-pushed the etcd-manager-image-volumes branch from 98273f3 to cdcae95 Compare August 5, 2025 11:42
@hakman
Copy link
Member Author

hakman commented Aug 5, 2025

/test pull-kops-e2e-k8s-aws-calico
/test pull-kops-e2e-k8s-gce-cilium
/test pull-kops-e2e-k8s-gce-ipalias

@hakman hakman force-pushed the etcd-manager-image-volumes branch from cdcae95 to 426222a Compare August 5, 2025 20:09
@hakman hakman marked this pull request as ready for review August 5, 2025 20:10
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2025
@hakman
Copy link
Member Author

hakman commented Aug 5, 2025

/hold for feedback

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2025
@hakman hakman force-pushed the etcd-manager-image-volumes branch from 426222a to b0dfac9 Compare August 8, 2025 07:16
@k8s-ci-robot k8s-ci-robot added area/api size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 8, 2025
@hakman hakman force-pushed the etcd-manager-image-volumes branch from b0dfac9 to f4caee4 Compare August 8, 2025 07:21
@hakman
Copy link
Member Author

hakman commented Aug 8, 2025

/retest

1 similar comment
@hakman
Copy link
Member Author

hakman commented Aug 8, 2025

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 8, 2025
@hakman hakman force-pushed the etcd-manager-image-volumes branch from f4caee4 to ad44ed4 Compare August 10, 2025 13:14
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 10, 2025
@hakman hakman force-pushed the etcd-manager-image-volumes branch from ad44ed4 to da4af99 Compare August 10, 2025 13:17
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 10, 2025
@hakman hakman added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2025
@hakman
Copy link
Member Author

hakman commented Aug 10, 2025

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2025
@hakman
Copy link
Member Author

hakman commented Aug 10, 2025

/retest

@hakman
Copy link
Member Author

hakman commented Aug 10, 2025

/override pull-kops-e2e-k8s-gce-ipalias
/test pull-kops-verify-terraform

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-gce-ipalias

In response to this:

/override pull-kops-e2e-k8s-gce-ipalias
/test pull-kops-verify-terraform

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit a758ae0 into kubernetes:master Aug 10, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet approved these changes

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hakman @k8s-ci-robot @rifelpet