-
Notifications
You must be signed in to change notification settings - Fork 416
Documentation for rc0 tasks #2819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mbianchidev The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/priority important-soon |
/cc @Vyom-Yadav |
Thanks a lot for this comprehensive doco @mbianchidev 🙏, I couldn't be able to review in details the full post-rc0-release-task but just left a few comments based on my personal thoughts. |
Tbh I'm little confused by the current organization and structure of the release-engineering docs when I review this PR and navigating back and forth a few linked pages inside it 😿, so I just wanted to suggest a revised structure that I think might make things a bit clearer. Would love to hear your thoughts, does the structure below make sense to you?
|
This is kinda similar to the bigger picture change I have in mind for these docs. My structure idea as mentioned above, it's more byte sized and designed SRE style, while there should still be an Can you post your comment here? #2797 (just edited to include a reorg of general content in the task itself) Thanks a lot for the review, great work 🙏 EDIT so it would be something like
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments to start as I continue to review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments on the checklist
/hold Do not merge until the RC.0 cut is done so we can validate these docs and fix the last few things. Will still create an issue using the latest template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this Matteo 💙
- [ ] Create a thread on #release-management: <!-- Paste link to slack --> | ||
- [ ] Remove EOL version jobs from test-infra (if it's the appropriate timing to do so) | ||
- [ ] Update milestone applier rules and check milestone requirements | ||
- [ ] Update kubekins-e2e variants.yaml with new version config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linking to examples, maybe: kubernetes/test-infra#34651. I know examples can go obsolete, but having some context helps (and examples can be updated if config management changes) (edit - same above example comment)
@mbianchidev We should consider adding a table of contents if possible to all new handbooks. |
@mbianchidev Please also fix |
Solved! |
Signed-off-by: mbianchidev <[email protected]>
This pull request introduces significant updates to the Kubernetes release engineering docs, focusing on post-release candidate (rc.0) tasks and branch management.
The changes I made aim to streamline the release workflow, improve clarity around the process and consolidate relevant documentation into a single SRE-handbook style source.
Similar to the work done for the release cut handbook.
What type of PR is this:
/kind documentation
What this PR does / why we need it:
We need to document the post rc.0 release tasks, currently fragmentally documented in multiple repos and in a format that is not easy to understand.
Which issue(s) this PR fixes:
Fixes #2776
Fixes #2826
Special notes for your reviewer:
I also tried my best to de-duplicate content.
The milestone rules applier is all done in Code Freeze/Thaw, so I removed also that bit.
Some considerations on alpha releases have been moved to the "new" release cut handbook, too.