-
Notifications
You must be signed in to change notification settings - Fork 7
fix: clean on detach #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: clean on detach #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolljee
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have a test dedicated to it
done |
etrousset
approved these changes
Feb 4, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
## [2.8.0-beta.1](v2.7.2...v2.8.0-beta.1) (2025-03-05) ### Features * **assetsGroups:** add service to handle groups related actions in a way that triggers pipe like devices and assets ([1a43fe7](1a43fe7)) * **deviceManagerEngine:** free devices after engine deletion ([#382](#382)) ([7c32f9f](7c32f9f)) * **groupmodels:** add possibility to set up group models with metadatas ([#392](#392)) ([19b2b70](19b2b70)) * measures should not be historized on asset ([#404](#404)) ([6a73786](6a73786)) * update measure model for localization ([#385](#385)) ([429678f](429678f)) ### Bug Fixes * clean on detach ([#400](#400)) ([cb8badf](cb8badf)) * last measured at ([#399](#399)) ([07830c0](07830c0)) * update documentation for indentations ([#401](#401)) ([fdd758e](fdd758e))
github-actions bot
pushed a commit
that referenced
this pull request
May 13, 2025
## [2.8.0](v2.7.2...v2.8.0) (2025-05-13) ### Features * **assetsGroups:** add service to handle groups related actions in a way that triggers pipe like devices and assets ([1a43fe7](1a43fe7)) * **deviceManagerEngine:** free devices after engine deletion ([#382](#382)) ([7c32f9f](7c32f9f)) * **groupmodels:** add possibility to set up group models with metadatas ([#392](#392)) ([19b2b70](19b2b70)) * measures should not be historized on asset ([#404](#404)) ([6a73786](6a73786)) * update measure model for localization ([#385](#385)) ([429678f](429678f)) ### Bug Fixes * clean on detach ([#400](#400)) ([cb8badf](cb8badf)) * last measured at ([#399](#399)) ([07830c0](07830c0)) * update documentation for indentations ([#401](#401)) ([fdd758e](fdd758e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the base branch of #391
Ticket KZLPRD-707