Skip to content

fix: clean on detach #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 4, 2025
Merged

fix: clean on detach #400

merged 5 commits into from
Feb 4, 2025

Conversation

thomas-mauran
Copy link
Member

@thomas-mauran thomas-mauran commented Feb 3, 2025

Fixes the base branch of #391
Ticket KZLPRD-707

@thomas-mauran thomas-mauran self-assigned this Feb 3, 2025
@thomas-mauran thomas-mauran changed the title Fix/clean on detach 2 dev fix: clean on detach Feb 3, 2025
Copy link
Contributor

@rolljee rolljee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have a test dedicated to it

@thomas-mauran
Copy link
Member Author

This should have a test dedicated to it

done

@etrousset etrousset merged commit cb8badf into 2-dev Feb 4, 2025
11 checks passed
@etrousset etrousset deleted the fix/clean-on-detach-2-dev branch February 4, 2025 11:16
github-actions bot pushed a commit that referenced this pull request Feb 4, 2025
## [2.8.0-dev.2](v2.8.0-dev.1...v2.8.0-dev.2) (2025-02-04)

### Features

* **groupmodels:** add possibility to set up group models with metadatas ([#392](#392)) ([19b2b70](19b2b70))

### Bug Fixes

* clean on detach ([#400](#400)) ([cb8badf](cb8badf))
github-actions bot pushed a commit that referenced this pull request Mar 5, 2025
## [2.8.0-beta.1](v2.7.2...v2.8.0-beta.1) (2025-03-05)

### Features

* **assetsGroups:** add service to handle groups related actions in a way that triggers pipe like devices and assets ([1a43fe7](1a43fe7))
* **deviceManagerEngine:** free devices after engine deletion ([#382](#382)) ([7c32f9f](7c32f9f))
* **groupmodels:** add possibility to set up group models with metadatas ([#392](#392)) ([19b2b70](19b2b70))
* measures should not be historized on asset ([#404](#404)) ([6a73786](6a73786))
* update measure model for localization ([#385](#385)) ([429678f](429678f))

### Bug Fixes

* clean on detach ([#400](#400)) ([cb8badf](cb8badf))
* last measured at ([#399](#399)) ([07830c0](07830c0))
* update documentation for indentations ([#401](#401)) ([fdd758e](fdd758e))
github-actions bot pushed a commit that referenced this pull request May 13, 2025
## [2.8.0](v2.7.2...v2.8.0) (2025-05-13)

### Features

* **assetsGroups:** add service to handle groups related actions in a way that triggers pipe like devices and assets ([1a43fe7](1a43fe7))
* **deviceManagerEngine:** free devices after engine deletion ([#382](#382)) ([7c32f9f](7c32f9f))
* **groupmodels:** add possibility to set up group models with metadatas ([#392](#392)) ([19b2b70](19b2b70))
* measures should not be historized on asset ([#404](#404)) ([6a73786](6a73786))
* update measure model for localization ([#385](#385)) ([429678f](429678f))

### Bug Fixes

* clean on detach ([#400](#400)) ([cb8badf](cb8badf))
* last measured at ([#399](#399)) ([07830c0](07830c0))
* update documentation for indentations ([#401](#401)) ([fdd758e](fdd758e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants