-
Notifications
You must be signed in to change notification settings - Fork 422
[Merged by Bors] - chore(*): fix some Decidable*
/Fintype` assumptions
#24986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
urkud
commented
May 18, 2025
@@ -105,7 +105,7 @@ variable {R : Type uR} {M : Type uM} {K : Type uK} {V : Type uV} {ι : Type uι} | |||
|
|||
section CommSemiring | |||
|
|||
variable [CommSemiring R] [AddCommMonoid M] [Module R M] [DecidableEq ι] | |||
variable [CommSemiring R] [AddCommMonoid M] [Module R M] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why this file compiles without any new classical
calls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked locally: because b
two lines below is not actually used, and \iota
only in section Finite
. So, I'd also remove the variable (b : Basis ι R M)
on the next line.
PR summary 5b933f2f0dImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
maintainer delegate
@@ -105,7 +105,7 @@ variable {R : Type uR} {M : Type uM} {K : Type uK} {V : Type uV} {ι : Type uι} | |||
|
|||
section CommSemiring | |||
|
|||
variable [CommSemiring R] [AddCommMonoid M] [Module R M] [DecidableEq ι] | |||
variable [CommSemiring R] [AddCommMonoid M] [Module R M] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked locally: because b
two lines below is not actually used, and \iota
only in section Finite
. So, I'd also remove the variable (b : Basis ι R M)
on the next line.
🚀 Pull request has been placed on the maintainer queue by grunweg. |
Thanks! bors d+ |
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
bors merge |
Pull request successfully merged into master. Build succeeded: |
Decidable*
/Fintype` assumptionsDecidable*
/Fintype` assumptions