Skip to content

chore(LapMatrix): use Matrix.mulVecLin instead of toLin' #24999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

urkud
Copy link
Member

@urkud urkud commented May 18, 2025

  • use Matrix.mulVec instead of Matrix.toLin' _ _; this is the simp-normal form;
  • use Matrix.mulVecLin _ instead of Matrix.toLin' _.

I'm working on applying these changes across the library, see #25012.


Open in Gitpod

@github-actions github-actions bot added the t-combinatorics Combinatorics label May 18, 2025
Copy link

PR summary f9ea33a8b5

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ card_connectedComponent_eq_finrank_ker_mulVecLin_lapMatrix
+ lapMatrix_mulVec_eq_zero_iff_forall_adj
+ lapMatrix_mulVec_eq_zero_iff_forall_reachable
+ mem_ker_mulVecLin_lapMatrix_of_connectedComponent

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@eric-wieser
Copy link
Member

The *ᵥ changes look like a clear win, as the simp-normal form, but I think the others need some explanation, and maybe make sense to apply mathlib-wide. Could you perhaps split the former, and make a new PR explaining the latter?

@urkud
Copy link
Member Author

urkud commented May 19, 2025

@eric-wieser I've opened a PR that aims to apply these changes everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-combinatorics Combinatorics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants