-
Notifications
You must be signed in to change notification settings - Fork 422
[Merged by Bors] - chore(Data/Fin): generalize Nontrivial
instance to NeZero
#25003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This makes the statement a bit weird, but we use `NeZero` frequently in downstream statements, and this makes it available.
PR summary a9677b456f
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.Data.Fin.Basic | 338 | 337 | -1 (-0.30%) |
Import changes for all files
Files | Import difference |
---|---|
47 filesMathlib.Algebra.Group.Fin.Tuple Mathlib.Algebra.Group.Pointwise.Set.ListOfFn Mathlib.Algebra.Group.Subgroup.MulOppositeLemmas Mathlib.AlgebraicTopology.SimplexCategory.Defs Mathlib.CategoryTheory.Limits.Shapes.Preorder.Fin Mathlib.Computability.Tape Mathlib.Control.Random Mathlib.Data.Countable.Basic Mathlib.Data.Fin.Basic Mathlib.Data.Fin.FlagRange Mathlib.Data.Fin.Rev Mathlib.Data.Fin.SuccPred Mathlib.Data.Fin.Tuple.Basic Mathlib.Data.Fin.Tuple.Curry Mathlib.Data.Fin.Tuple.Embedding Mathlib.Data.Fin.Tuple.Take Mathlib.Data.Fin.VecNotation Mathlib.Data.List.ChainOfFn Mathlib.Data.List.FinRange Mathlib.Data.List.NodupEquivFin Mathlib.Data.List.OfFn Mathlib.Data.List.Sort Mathlib.Data.List.Sublists Mathlib.Data.Multiset.Antidiagonal Mathlib.Data.Multiset.Powerset Mathlib.Data.Multiset.Sort Mathlib.Data.Num.Bitwise Mathlib.Data.Rat.Encodable Mathlib.Data.Sym.Basic Mathlib.Data.Vector.Basic Mathlib.Data.Vector.MapLemmas Mathlib.Data.Vector.Mem Mathlib.Data.Vector.Snoc Mathlib.Data.Vector.Zip Mathlib.GroupTheory.FreeGroup.Reduce Mathlib.Logic.Encodable.Basic Mathlib.Logic.Encodable.Lattice Mathlib.Logic.Equiv.Fin.Basic Mathlib.Logic.Function.FromTypes Mathlib.Logic.Function.OfArity Mathlib.Logic.Small.List Mathlib.Order.Fin.Basic Mathlib.Order.Fin.Finset Mathlib.Order.Fin.Tuple Mathlib.Order.Interval.Set.Fin Mathlib.SetTheory.ZFC.Basic Mathlib.Tactic.DeriveEncodable |
-1 |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
The doc-module for script/declarations_diff.sh
contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relative
value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolute
value is therelative
value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maintainer merge
🚀 Pull request has been placed on the maintainer queue by jsm28. |
bors merge |
This makes the statement a bit weird, but we use `NeZero` frequently in downstream statements, and this makes it available.
Pull request successfully merged into master. Build succeeded: |
Nontrivial
instance to NeZero
Nontrivial
instance to NeZero
This makes the statement a bit weird, but we use
NeZero
frequently in downstream statements, and this makes it available.