Skip to content

[Merged by Bors] - chore(Data/Fin): generalize Nontrivial instance to NeZero #25003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

eric-wieser
Copy link
Member

This makes the statement a bit weird, but we use NeZero frequently in downstream statements, and this makes it available.


Open in Gitpod

This makes the statement a bit weird, but we use `NeZero` frequently in downstream statements, and this makes it available.
@eric-wieser eric-wieser requested a review from jsm28 May 18, 2025 19:43
@eric-wieser eric-wieser added easy < 20s of review time. See the lifecycle page for guidelines. t-data Data (lists, quotients, numbers, etc) labels May 18, 2025
Copy link

github-actions bot commented May 18, 2025

PR summary a9677b456f

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Data.Fin.Basic 338 337 -1 (-0.30%)
Import changes for all files
Files Import difference
47 files Mathlib.Algebra.Group.Fin.Tuple Mathlib.Algebra.Group.Pointwise.Set.ListOfFn Mathlib.Algebra.Group.Subgroup.MulOppositeLemmas Mathlib.AlgebraicTopology.SimplexCategory.Defs Mathlib.CategoryTheory.Limits.Shapes.Preorder.Fin Mathlib.Computability.Tape Mathlib.Control.Random Mathlib.Data.Countable.Basic Mathlib.Data.Fin.Basic Mathlib.Data.Fin.FlagRange Mathlib.Data.Fin.Rev Mathlib.Data.Fin.SuccPred Mathlib.Data.Fin.Tuple.Basic Mathlib.Data.Fin.Tuple.Curry Mathlib.Data.Fin.Tuple.Embedding Mathlib.Data.Fin.Tuple.Take Mathlib.Data.Fin.VecNotation Mathlib.Data.List.ChainOfFn Mathlib.Data.List.FinRange Mathlib.Data.List.NodupEquivFin Mathlib.Data.List.OfFn Mathlib.Data.List.Sort Mathlib.Data.List.Sublists Mathlib.Data.Multiset.Antidiagonal Mathlib.Data.Multiset.Powerset Mathlib.Data.Multiset.Sort Mathlib.Data.Num.Bitwise Mathlib.Data.Rat.Encodable Mathlib.Data.Sym.Basic Mathlib.Data.Vector.Basic Mathlib.Data.Vector.MapLemmas Mathlib.Data.Vector.Mem Mathlib.Data.Vector.Snoc Mathlib.Data.Vector.Zip Mathlib.GroupTheory.FreeGroup.Reduce Mathlib.Logic.Encodable.Basic Mathlib.Logic.Encodable.Lattice Mathlib.Logic.Equiv.Fin.Basic Mathlib.Logic.Function.FromTypes Mathlib.Logic.Function.OfArity Mathlib.Logic.Small.List Mathlib.Order.Fin.Basic Mathlib.Order.Fin.Finset Mathlib.Order.Fin.Tuple Mathlib.Order.Interval.Set.Fin Mathlib.SetTheory.ZFC.Basic Mathlib.Tactic.DeriveEncodable
-1

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Collaborator

@jsm28 jsm28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by jsm28.

@b-mehta
Copy link
Contributor

b-mehta commented May 19, 2025

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge labels May 19, 2025
mathlib-bors bot pushed a commit that referenced this pull request May 19, 2025
This makes the statement a bit weird, but we use `NeZero` frequently in downstream statements, and this makes it available.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented May 19, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Data/Fin): generalize Nontrivial instance to NeZero [Merged by Bors] - chore(Data/Fin): generalize Nontrivial instance to NeZero May 19, 2025
@mathlib-bors mathlib-bors bot closed this May 19, 2025
@mathlib-bors mathlib-bors bot deleted the eric-wieser-patch-3 branch May 19, 2025 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants