Skip to content

[Merged by Bors] - feat: add a congruence lemma for orthogonalProjection #25004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

eric-wieser
Copy link
Member

While it is still tricky to rewrite with rw, this makes it work with simp.


Open in Gitpod

While it is still tricky to rewrite with `rw`, this makes it work with `simp`.
@eric-wieser eric-wieser requested a review from jsm28 May 18, 2025 19:47
@eric-wieser eric-wieser added the t-euclidean-geometry Affine and axiomatic geometry label May 18, 2025
Copy link

github-actions bot commented May 18, 2025

PR summary 06561e8b57

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ orthogonalProjection_congr

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Collaborator

@jsm28 jsm28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by jsm28.

@dupuisf
Copy link
Contributor

dupuisf commented May 18, 2025

bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge labels May 18, 2025
mathlib-bors bot pushed a commit that referenced this pull request May 18, 2025
While it is still tricky to rewrite with `rw`, this makes it work with `simp`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented May 18, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: add a congruence lemma for orthogonalProjection [Merged by Bors] - feat: add a congruence lemma for orthogonalProjection May 18, 2025
@mathlib-bors mathlib-bors bot closed this May 18, 2025
@mathlib-bors mathlib-bors bot deleted the eric-wieser/proj-congr branch May 18, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-euclidean-geometry Affine and axiomatic geometry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants