feat(Valuation/DiscreteValuationRel): val relations with compatible valuations to Zm0 are IsDiscrete #27213
+161
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LeOne with a proof_wanted for the reverse implication
…ingleton` and general DenselyOrdered API and instances needed for showing that valuations mapping into Zm0 are discrete and thus DVR
for proving that it is not densely ordered for PIR -> DVR for valuations
and generalize to LT
A helper lemma, in the style of `denselyOrdered_iff_of_orderIsoClass` but slightly weaker (needs LinearOrder), but works to transport across order-dual types like WithBot (X^od) to WithBot X
…orders are trivial
… Zm0 or NNReal valuation and then provide it for Q_[p]
This reverts commit 843e33b.
PR summary 962b24680eImport changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.NumberTheory.Padics.ValuativeRel | 1478 | 1752 | +274 (+18.54%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.NumberTheory.Padics.ValuativeRel |
274 |
Mathlib.RingTheory.Valuation.DiscreteValuativeRel (new file) |
1748 |
Declarations diff
+ IsDiscrete.of_compatible_withZeroMulInt
+ ValuativeRel.IsRankLeOne.of_compatible_mulArchimedean
+ ValueGroupWithZero.embed
+ ValueGroupWithZero.embed_strictMono
+ ValueGroupWithZero.embed_valuation_apply
+ compatible_comap_of_extension
+ instance : IsRankLeOne ℚ_[p] := .of_compatible_mulArchimedean mulValuation
+ instance [IsRankLeOne R] : MulArchimedean (ValueGroupWithZero R) := by
+ nonempty_orderIso_withZeroMul_int_iff
+ val_posSubmonoid_ne_zero
+ valuation_eq_zero_iff
+ valuation_posSubmonoid_ne_zero
+ valuation_posSubmonoid_ne_zero_of_compatible
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
pechersky
added
t-number-theory
|
This pull request has conflicts, please merge |
leanprover-community-bot-assistant
added
the
merge-conflict
…chimedean Thanks to the ongoing effort to get the Hahn Embedding theorem into Mathlib
It's in a later file with a heavier import, but I think that's not an issue
github-actions
bot
removed
the
merge-conflict
github-actions
bot
added
the
large-import
kckennylau
reviewed
Jul 25, 2025
|
|
||
| namespace ValuativeRel | ||
|
|
||
| variable {R : Type} [CommRing R] [ValuativeRel R] |
There was a problem hiding this comment.
Suggested change
| variable {R : Type} [CommRing R] [ValuativeRel R] | |
| variable {R : Type*} [CommRing R] [ValuativeRel R] |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Int.set_denselyOrdered_iff_subsingleton#27112StrictMono.denselyOrdered_range#27208