Skip to content

fix list error not containing index information, issue #16 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025

Conversation

fenollp
Copy link
Contributor

@fenollp fenollp commented Jun 3, 2025

Closes #16

@fenollp
Copy link
Contributor Author

fenollp commented Jun 3, 2025

Together with #17 and #14 this addresses all notes from #16, except the (cosmetic) format! part.

@fenollp fenollp force-pushed the maperr branch 2 times, most recently from 822f568 to 7abf6e4 Compare June 3, 2025 14:22
@Adphi
Copy link
Member

Adphi commented Jun 3, 2025

Thanks !

@fenollp
Copy link
Contributor Author

fenollp commented Jun 3, 2025

Yes sorry for the noise.

Would you consider publishing this as your own crate on crates.io? Leaving the PR open but probably simplifying usage of the plugin....

@Adphi Adphi merged commit 7e86d91 into linka-cloud:main Jun 3, 2025
8 checks passed
@fenollp fenollp deleted the maperr branch June 3, 2025 14:35
@Adphi
Copy link
Member

Adphi commented Jun 3, 2025

Yes sorry for the noise.

No worries at all!

Would you consider publishing neoeinstein/protoc-gen-prost#107 as your own crate on crates.io

Any idea for the crate name as protoc-gen-prost-validate is not available ?

@fenollp
Copy link
Contributor Author

fenollp commented Jun 3, 2025

Ah indeed. We could try https://crates.io/support?crate=protoc-gen-prost-validate&inquire=crate-violation but I'd suggest the nicer and faster "let's register a new one" and so I suggest protocgen-prost-validate.

I'm sure we'll eventually come around to the initial name, once that PR gets merged

@Adphi
Copy link
Member

Adphi commented Jun 3, 2025

I believe using protocgen-prost-validate could cause issues with buf, since protoc plugins are expected to have a protoc-gen- prefix.
Maybe protoc-gen-rust-validate or protoc-gen-prostvalidate ?

@fenollp
Copy link
Contributor Author

fenollp commented Jun 3, 2025

You're right, I checked this at first but badly. I'm go for protoc-gen-prostvalidate :)

@fenollp fenollp mentioned this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ineffectual map_err on iterators looses item index information
2 participants