fix(tracing): Remove opentelemetry vendoring #4025
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to vendor the opentelemetry protobufs because we relied on a version of tonic that `opentelemetry-sdk` didn't support. Now that we've upgraded tonic, we can remove the vendoring and use the official APIs. Signed-off-by: Scott Fleener <[email protected]>
|
@sfleen does this put us in a position where we are unable to take updates? would it be better to drive the tonic update first? |
|
It would probably prevent us if we don't update tonic and friends first. |
# Conflicts: # Cargo.lock # opentelemetry-proto/src/gen/opentelemetry.proto.collector.trace.v1.rs
Signed-off-by: Scott Fleener <[email protected]>
|
With #4066 merged, opentelemetry deps are now on the most recent version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to vendor the opentelemetry protobufs because we relied on a version of tonic that
opentelemetry-sdkdidn't support. Now that we've upgraded tonic, we can remove the vendoring and use the official APIs.Note that we had to downgrade opentelemetry from 0.30 to 0.29, once we update to tonic 0.13 we can upgrade back.