Skip to content

Conversation

hcwagner
Copy link

This PR is focused on adding support for IP Reservation while using NodeBalancers as a Service LoadBalancer. This assume that the customer has:

Reserved an IP through Linode CLI, CM, terraform, etc.
Supplies the reserved IP attached to their account through the provided Annotation

@hcwagner hcwagner self-assigned this Aug 14, 2025
@hcwagner hcwagner added the new-feature for new features in the changelog. label Aug 14, 2025
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 80.63492% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.06%. Comparing base (36df8ec) to head (35ad816).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
cloud/nodeipam/ipam/cloud_allocator.go 60.81% 24 Missing and 5 partials ⚠️
cloud/linode/route_controller.go 70.21% 12 Missing and 2 partials ⚠️
cloud/linode/cloud.go 72.00% 4 Missing and 3 partials ⚠️
cloud/linode/cilium_loadbalancers.go 68.75% 3 Missing and 2 partials ⚠️
cloud/linode/loadbalancers.go 94.02% 2 Missing and 2 partials ⚠️
cloud/linode/utils/common.go 91.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
- Coverage   72.17%   72.06%   -0.12%     
==========================================
  Files          19       19              
  Lines        3551     3658     +107     
==========================================
+ Hits         2563     2636      +73     
- Misses        751      781      +30     
- Partials      237      241       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

hcwagner and others added 26 commits August 25, 2025 10:56
…ated-with-reserved-ip-nb-range testcases. Removed the liveness check in lb-created-with-specified-nb-id-reserved and lb-created-with-reserved-ip-and-nb-id-annotations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature for new features in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants