Skip to content

[Wayland] Implement xdg-activation-v1 protocol #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Sunderland93
Copy link
Contributor

Adapted from Mutter with some additional changes https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1845

@Sunderland93
Copy link
Contributor Author

Sunderland93 commented May 17, 2025

This part works well. If you start Firefox on the first workspace, switch to the second workspace and run, for example, System Info there, where you click on Upload system information - the Firefox window on the first workspace receives an activation token (according to the output of WAYLAND_DEBUG=1), and its indicator on the panel starts to glow (urgent state). However, there is no automatic switch to the first workspace and focus on the window with Firefox, it still requires manual switching to the first workspace and maximizing the window. I think this is a problem of Cinnamon itself, which cannot yet correctly handle window activation. @mtwebster any suggestions?

@mtwebster
Copy link
Member

mtwebster commented Jul 24, 2025

It looks like in your test case the activation is being caught in windowAttentionHandler.js, and meta_window_activate() is called. The timestamp is 0 so I think it ends up returning at line 4174 in window.c.

In an x11 session, the window does not go thru windowAttentionHandler, but activation occurs from somewhere else, with a valid timestamp, so workspace switching can occur. I haven't had a chance to figure out what's causing that activation yet, and maybe it shouldn't be the same one wayland uses - getting a proper timestamp may be what we need to figure out.

edit: (sorry for the delay getting around to looking at these, life had other plans)

@Sunderland93
Copy link
Contributor Author

Latest commit fixes Firefox's window raising (no need to manual maximizing window), but issue with automatic switch to workspace (where Firefox is) is still here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants