Skip to content

Add a kvcache example deployment #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nerdalert
Copy link
Member

  • Enables redis and ENABLE_KVCACHE_AWARE_SCORER

@nerdalert nerdalert marked this pull request as draft June 3, 2025 18:54
@nerdalert nerdalert force-pushed the kvcache-example-overrides branch 3 times, most recently from 5b9b574 to 8d3e6c6 Compare June 4, 2025 16:48
- Enables redis and ENABLE_KVCACHE_AWARE_SCORER

Signed-off-by: Brent Salisbury <[email protected]>
@nerdalert nerdalert force-pushed the kvcache-example-overrides branch from 8d3e6c6 to afda7c0 Compare June 6, 2025 04:59
@nerdalert nerdalert marked this pull request as ready for review June 6, 2025 14:27
Copy link
Member

@Gregory-Pereira Gregory-Pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some questions

- name: ENABLE_PREFIX_AWARE_SCORER
value: "false"
- name: ENABLE_LOAD_AWARE_SCORER
value: "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More of a question then a comment, but do we want both load scorer and KVCache aware scorer or just 1?

- name: ENABLE_SESSION_AWARE_SCORER
value: "false"
- name: PD_ENABLED
value: "false"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont we need P/D Enabled for KVCache Aware routing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants