Skip to content

Add a VimeoEmbed component to embed public or private vimeo videos #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

petecheslock
Copy link
Collaborator

In looking at how to embed videos on docusaurus, I think the issue that might have previously happened was that the vimeo video is "public but only with the link". This means that the URL includes the video ID but also a hash/key that needs to be included in the request.

This code will work also if you exclude the hash which is needed when any videos are made "public".

@KPRoche Check this out and let me know what you think. This is mostly a proof of concept, I'm not entirely sure where we should/could put the video and if the component is in the right place.

@petecheslock petecheslock requested a review from KPRoche June 13, 2025 16:54
@petecheslock petecheslock self-assigned this Jun 13, 2025
@KPRoche
Copy link
Collaborator

KPRoche commented Jun 13, 2025

Were you able to create a preview site for this?

@petecheslock
Copy link
Collaborator Author

That is a great question - how do we create preview sites? Would this be like creating a github action or other solution?

@KPRoche
Copy link
Collaborator

KPRoche commented Jun 13, 2025

That is a great question - how do we create preview sites? Would this be like creating a github action or other solution?

The trick is to include all branches when you create your fork, so you have the proper gh-pages structure hiding in your forked repository. Then you can run the existing deployment action against your fork of the repository.

I describe this in the kubestellar contribution system, but the procedure is the same:
https://docs.kubestellar.io/release-0.27.2/contribution-guidelines/operations/document-management/#creating-a-fork-that-can-use-the-generate-and-push-docs-action

If you did not include gh-pages when you created your fork:

If you forgot to include it, you can add it to your existing fork if you go to the branches tab for your fork in the github website:
image

Now Click on the New Branch button (near upper right of the page)

Fill out the fields in the dialog box thusly:

  • Name the new branch gh-pages
  • Select llm-d/llm-d.github.io as the source and gh-pages as the source branch
    image
  • Click on Create New Branch button
  • The build and deploy pages action will probably work now on your fork to create preview pages at petecheslock.github.io/llm-d.github.io

@KPRoche
Copy link
Collaborator

KPRoche commented Jun 13, 2025

For instance, mine is here: https://kproche.github.io/llm-d.github.io/

@KPRoche
Copy link
Collaborator

KPRoche commented Jun 13, 2025

NOTE: you do need to modify the base url, project, and org in the docusaurus.config.js file for it to work in your github pages. There should be enough hints in the file from Jesse's and my forks to make it easy to follow.

I tried copying your changes into a branch on my fork and it doesn't render.

@petecheslock petecheslock closed this by deleting the head repository Jun 16, 2025
@petecheslock
Copy link
Collaborator Author

@KPRoche I'll close this PR so that I can fix my repo to get the builds going - just easiest to nuke my fork and start fresh. Then i'll open a new one with a preview and a clean branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants