Add a VimeoEmbed component to embed public or private vimeo videos #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In looking at how to embed videos on docusaurus, I think the issue that might have previously happened was that the vimeo video is "public but only with the link". This means that the URL includes the video ID but also a hash/key that needs to be included in the request.
This code will work also if you exclude the
hash
which is needed when any videos are made "public".@KPRoche Check this out and let me know what you think. This is mostly a proof of concept, I'm not entirely sure where we should/could put the video and if the component is in the right place.