Skip to content

Fixing broken links. #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 26, 2025
Merged

Fixing broken links. #62

merged 6 commits into from
Jun 26, 2025

Conversation

jjasghar
Copy link
Collaborator

this should fix the broken links from Jun 25ths check.

@jjasghar
Fixing broken links.
e151aa4 
this should fix the broken links from Jun 25ths check.

Signed-off-by: JJ Asghar <[email protected]>
@netlify Netlify
Copy link

netlify bot commented Jun 25, 2025 •
edited
Loading

✅ Deploy Preview for elaborate-kangaroo-25e1ee ready!

Name Link
🔨 Latest commit 6eca358
🔍 Latest deploy log https://app.netlify.com/projects/elaborate-kangaroo-25e1ee/deploys/685c9e89dbd57700085c30e3
😎 Deploy Preview https://deploy-preview-62--elaborate-kangaroo-25e1ee.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

jjasghar
jjasghar commented Jun 25, 2025
View reviewed changes
@jjasghar jjasghar mentioned this pull request Jun 25, 2025
Closed
@jjasghar
Copy link
Collaborator Author

Ok, it looks like it's still not working:

============================================================
2025-06-25 16:57:37,639 - ERROR - BROKEN LINKS FOUND (HTTP 404 & 500 ONLY):
2025-06-25 16:57:37,639 - ERROR - ============================================================
2025-06-25 16:57:37,639 - ERROR -
❌ BROKEN LINK: https://llm-d.ai/docs/guide/installation/prerequisites
2025-06-25 16:57:37,639 - ERROR -    📄 Found on page: https://deploy-preview-62--elaborate-kangaroo-25e1ee.netlify.app/
2025-06-25 16:57:37,639 - ERROR -    💥 Error: HTTP 404 - Not Found
2025-06-25 16:57:37,639 - ERROR -
❌ BROKEN LINK: https://llm-d.ai/docs/guide/installation/quickstart
2025-06-25 16:57:37,639 - ERROR -    📄 Found on page: https://deploy-preview-62--elaborate-kangaroo-25e1ee.netlify.app/
2025-06-25 16:57:37,639 - ERROR -    💥 Error: HTTP 404 - Not Found
2025-06-25 16:57:37,639 - ERROR -
❌ BROKEN LINK: https://deploy-preview-62--elaborate-kangaroo-25e1ee.netlify.app/docs/architecture/00_architecture.md
2025-06-25 16:57:37,639 - ERROR -    📄 Found on page: https://deploy-preview-62--elaborate-kangaroo-25e1ee.netlify.app/docs/guide
2025-06-25 16:57:37,639 - ERROR -    💥 Error: HTTP 404 - Not Found

I'll keep playing with it

jjasghar added 4 commits June 25, 2025 17:03
@jjasghar
fixed mdx and relitive paths
4115890 
fixed mdx and relitive paths for docs

Signed-off-by: JJ Asghar <[email protected]>
@jjasghar
Removed endings of files
69cf11f 
Not sure if this will actually work...

Signed-off-by: JJ Asghar <[email protected]>
@jjasghar
Fixing the architecture links.
d144936 
- fixed some white space
- fixed the architecture link

Signed-off-by: JJ Asghar <[email protected]>
@jjasghar
we need "I" not "i"
544e14b 
docusourus can redirect, but still gives a 404 first.

Signed-off-by: JJ Asghar <[email protected]>
@jjasghar
removed the hard coded llm-d.ai url
6eca358 
This will work relitive now.

Signed-off-by: JJ Asghar <[email protected]>
@jjasghar
Copy link
Collaborator Author

Huzzah!

============================================================
2025-06-25 20:22:19,469 - INFO - LINK VERIFICATION RESULTS
2025-06-25 20:22:19,469 - INFO - ============================================================
2025-06-25 20:22:19,470 - INFO - Total links checked: 322
2025-06-25 20:22:19,471 - INFO - Successful links: 322
2025-06-25 20:22:19,471 - INFO - Broken links: 0
2025-06-25 20:22:19,471 - INFO -
✅ No broken links found (checked for HTTP 404 & 500 errors only)!

✅ All links verified successfully! (No HTTP 404 or 500 errors found)

@jjasghar
Copy link
Collaborator Author

@jessicachitas if you're good with this please merge when you can :)

jessicachitas
jessicachitas approved these changes Jun 26, 2025
View reviewed changes
Copy link
Collaborator

@jessicachitas jessicachitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@jessicachitas jessicachitas merged commit 93904d6 into llm-d:main Jun 26, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicachitas jessicachitas jessicachitas approved these changes

@petecheslock petecheslock Awaiting requested review from petecheslock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjasghar @petecheslock @jessicachitas