Skip to content

🐛 fix(chat): Improve response animation merging logic #8159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sxjeru
Copy link
Contributor

@sxjeru sxjeru commented Jun 12, 2025

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

修复带有 responseAnimation.speed 参数的 provider 输出。

📝 补充信息 | Additional Information

Copy link

vercel bot commented Jun 12, 2025

@sxjeru is attempting to deploy a commit to the LobeHub Community Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 12, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@lobehubbot
Copy link
Member

👍 @sxjeru

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link
Contributor

gru-agent bot commented Jun 12, 2025

TestGru Assignment

Summary

Link CommitId Status Reason
Detail a0db652 ✅ Finished

Files

File Pull Request
src/services/chat.ts ❌ Failed (I failed to setup the environment.)

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

Copy link

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.89%. Comparing base (dd4ab3f) to head (a0db652).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main    #8159     +/-   ##
=========================================
  Coverage   87.89%   87.89%             
=========================================
  Files         836      836             
  Lines       61804    61807      +3     
  Branches     5650     3925   -1725     
=========================================
+ Hits        54322    54325      +3     
  Misses       7482     7482             
Flag Coverage Δ
app 87.89% <100.00%> (+<0.01%) ⬆️
server 95.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

vercel bot commented Jun 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2025 3:22am

@Wxh16144
Copy link
Contributor

哎呀,看 discord 才知道你这边先修复了..

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Oh, I only found out that you have fixed it first after looking at discord.

@Wxh16144
Copy link
Contributor

哎呀,看 discord 才知道你这边先修复了..

我在 #8160 这 PR 修复了?看看方式是不是差不多。

@sxjeru
Copy link
Contributor Author

sxjeru commented Jun 12, 2025

@Wxh16144 感觉你那个更好,我这边先关了吧。

@sxjeru sxjeru closed this Jun 12, 2025
@sxjeru sxjeru deleted the fix1 branch June 12, 2025 05:39
@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@Wxh16144 It's OK, then I'll close it first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

更新到最新版(1.94.4)导致火山引擎API不可用
3 participants