Add support for SNMPv3 context engine ID and context name to snmptrap
#76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmocosta
reviewed
Jul 31, 2025
Comment on lines
+308
to
+310
| if (pdu instanceof ScopedPDU) { | ||
| trapEvent.put("context_engine_id", ((ScopedPDU)pdu).getContextEngineID()); | ||
| trapEvent.put("context_name", ((ScopedPDU)pdu).getContextName()); |
There was a problem hiding this comment.
Suggested change
| if (pdu instanceof ScopedPDU) { | |
| trapEvent.put("context_engine_id", ((ScopedPDU)pdu).getContextEngineID()); | |
| trapEvent.put("context_name", ((ScopedPDU)pdu).getContextName()); | |
| if (pdu instanceof ScopedPDU) { | |
| final ScopedPDU scopedPDU = (ScopedPDU) pdu; | |
| trapEvent.put("context_engine_id", String.valueOf(scopedPDU.getContextEngineID())); | |
| trapEvent.put("context_name", scopedPDU.getContextName()); |
Both fields are OctetString and need to be parse to string before setting them as a Logstash event field, otherwise a Java::OrgLogstash::MissingConverterException is raised.
| @@ -60,6 +60,8 @@ The value is stored in the `@metadata` where it can be used by other plugins in | |||
| |ECS disabled, v1, v8 |Availability|Description | |||
| |[@metadata][input][snmptrap][pdu][agent_addr]|`SNMPv1`|Network address of the object generating the trap | |||
| |[@metadata][input][snmptrap][pdu][community]|`SNMPv1` `SNMPv2c`|SNMP community | |||
| |[@metadata][input][snmptrap][pdu][context_engine_id]|`SNMPv3`|SNMP context engine id | |||
There was a problem hiding this comment.
Suggested change
| |[@metadata][input][snmptrap][pdu][context_engine_id]|`SNMPv3`|SNMP context engine id | |
| |[@metadata][input][snmptrap][pdu][context_engine_id]|`SNMPv3`|SNMP context engine ID |
| @@ -1,3 +1,6 @@ | |||
| ## 4.1.0 | |||
| - Add support for SNMPv3 `context engine ID` and `context name` to the `snmptrap` input[xxx]() | |||
There was a problem hiding this comment.
Suggested change
| - Add support for SNMPv3 `context engine ID` and `context name` to the `snmptrap` input[xxx]() | |
| - Add support for SNMPv3 `context engine ID` and `context name` to the `snmptrap` input [#76](https://github.com/logstash-plugins/logstash-integration-snmp/pull/76) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates: #12