-
Notifications
You must be signed in to change notification settings - Fork 7
version 1.6, - new search, infinite map handling, etc #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # plugins/maplist/Maplist.ts # src/services/MapService.ts
Co-authored-by: Feláček <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, i think we should honestly just push this update now so we can start refactoring some of the uglier services (map, records etc.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
It seems docker cannot build rn because of this bug, even though everything was fine 2 weeks ago... Maybe they release the update to npm soon? Otherwise we'll have to actually solve this ourselves (no idea why it doesn't work all of a sudden, and only on docker too...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works on my machine...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice Code. Great Fortune
merge to main whenever ready.
current changes: