Skip to content

version 1.6, - new search, infinite map handling, etc #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 117 commits into from
Nov 29, 2024
Merged

version 1.6, - new search, infinite map handling, etc #257

merged 117 commits into from
Nov 29, 2024

Conversation

wsrvn
Copy link
Collaborator

@wsrvn wsrvn commented May 28, 2024

merge to main whenever ready.

current changes:

  1. hypothetically infinite maps handling on the server
  2. way faster search
  3. nickname->player translation in admin commands
  4. various ui fixes
  5. some small bug fixes

felacek and others added 30 commits March 30, 2024 13:12
# Conflicts:
#	plugins/maplist/Maplist.ts
#	src/services/MapService.ts
@wsrvn wsrvn marked this pull request as ready for review November 18, 2024 05:16
@wsrvn wsrvn requested review from lythx and felacek November 18, 2024 05:16
Copy link
Collaborator

@felacek felacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i think we should honestly just push this update now so we can start refactoring some of the uglier services (map, records etc.)

Copy link
Owner

@lythx lythx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@felacek
Copy link
Collaborator

felacek commented Nov 25, 2024

It seems docker cannot build rn because of this bug, even though everything was fine 2 weeks ago... Maybe they release the update to npm soon? Otherwise we'll have to actually solve this ourselves (no idea why it doesn't work all of a sudden, and only on docker too...)

@felacek felacek self-requested a review November 28, 2024 17:25
Copy link
Collaborator

@felacek felacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on my machine...

@felacek felacek requested a review from lythx November 28, 2024 17:26
Copy link
Owner

@lythx lythx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice Code. Great Fortune

@wsrvn wsrvn merged commit 8150759 into main Nov 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants