-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Allow queue-specific configuration to exceed the default max-messages value #40110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
Conversation
Hi @baudeval. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Failed to run the builds. Please try to re-run them later. |
@magento run all tests |
The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email [email protected]. |
The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email [email protected]. |
4 similar comments
The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email [email protected]. |
The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email [email protected]. |
The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email [email protected]. |
The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email [email protected]. |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ The change looks technically correct.
Thanks for catching this issue, I'll backport the solution to one of my projects.
Description (*)
Allow queue-specific configuration to exceed the default max-messages value
Currently, when configuring a specific max-messages value in queue_consumer.xml (e.g., 400000), the consumer command still uses the lower global default (e.g., 10000), because the logic applies min($consumer->getMaxMessages(), $maxMessages).
This change updates the behavior so that, if a queue has a specific max-messages configuration, it takes precedence over the default value.
Example:
Configured in queue_consumer.xml: max-messages = 400000
Default value: 10000
Before: the command uses --max-messages=10000
After: the command correctly uses --max-messages=400000
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Create queue with max message higter default value
Questions or comments
Contribution checklist (*)