-
-
Notifications
You must be signed in to change notification settings - Fork 834
[Draft] Allow underzoom and overpan of a single-copy world #4733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…tates the zoom-out limit
Update with latest main
…y don't appear when underzoom off
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4733 +/- ##
=======================================
Coverage 87.75% 87.75%
=======================================
Files 247 247
Lines 33656 33747 +91
Branches 2201 2167 -34
=======================================
+ Hits 29536 29616 +80
- Misses 3132 3148 +16
+ Partials 988 983 -5 ☔ View full report in Codecov by Sentry. |
can you elaborate? unit tests? in case you need assistance, what do you see now when you run The The |
Is this something that would be possible to merge if the tests are resolved? Would be happy to assist getting this moved forward. |
Yes, I'd be happy if you helped — but it will be more work than just tests:
|
Launch Checklist
Draft PR to check the implications of current underzoom design. I am not currently able to run local tests.
Fixes #4510, #4591 by allowing the map to be underzoomed and overpanned:
Explanation of current design at #4510 (comment).
Demo:
https://larsmaxfield.github.io/swings/maplibre-underzoom/unbounded.html

CHANGELOG.md
under the## main
section.