Increase the high-end GCC version in qt-ci #3488
Conversation
Signed-off-by: Ferenc Géczi <[email protected]>
|
The change is ok, but the test will have to be fixed. |
|
@ntadej Thanks for the quick feedback! Are we sure that the test is at fault? Because this is not an assertion failure, but simply a call to Either the if statement here should ensure that none of the dimensions is 0: void fill(uint8_t value) {
if (valid()) {Or perhaps the bool valid() should return false if any of the dimensions is |
Fixes the following kind of errors:
```
In function ‘constexpr typename __gnu_cxx::__enable_if<std::__is_byte<_Tp>::__value, void>::__type std::__fill_a1(_Tp*, _Tp*, const _Tp&) [with _Tp = unsigned char]’,
inlined from ‘constexpr void std::__fill_a(_FIte, _FIte, const _Tp&) [with _FIte = unsigned char*; _Tp = unsigned char]’ at /usr/include/c++/14/bits/stl_algobase.h:998:21,
inlined from ‘constexpr void std::fill(_ForwardIterator, _ForwardIterator, const _Tp&) [with _ForwardIterator = unsigned char*; _Tp = unsigned char]’ at /usr/include/c++/14/bits/stl_algobase.h:1029:20,
inlined from ‘void mbgl::Image<Mode>::fill(uint8_t) [with mbgl::ImageAlphaMode Mode = mbgl::ImageAlphaMode::Exclusive]’ at /home/runner/work/maplibre-native/maplibre-native/source/include/mbgl/util/image.hpp:82:22,
inlined from ‘void mbgl::Image<Mode>::resize(mbgl::Size) [with mbgl::ImageAlphaMode Mode = mbgl::ImageAlphaMode::Exclusive]’ at /home/runner/work/maplibre-native/maplibre-native/source/include/mbgl/util/image.hpp:93:26,
inlined from ‘virtual void Image_Resize_Test::TestBody()’ at /home/runner/work/maplibre-native/maplibre-native/source/test/util/image.test.cpp:101:17:
/usr/include/c++/14/bits/stl_algobase.h:972:25: error: ‘void* __builtin_memset(void*, int, long unsigned int)’ offset 0 is out of the bounds [0, 0] [-Werror=array-bounds=]
972 | __builtin_memset(__first, static_cast<unsigned char>(__tmp), __len);
| ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
Signed-off-by: Ferenc Géczi <[email protected]>
|
So I have surmised from the |
| @@ -77,7 +77,7 @@ class Image : private util::noncopyable { | |||
| size_t bytes() const { return stride() * size.height; } | |||
|
|
|||
| void fill(uint8_t value) { | |||
| if (valid()) { | |||
| if (valid() && !size.isEmpty()) { | |||
There was a problem hiding this comment.
Already implied by valid()
There was a problem hiding this comment.
Right, I have missed that. Then this needs another look at, how come isEmpty returns flase, despite the size being {0, 0}.
No description provided.