Fix(logout): avoid an infinite loop when loading the demo apps for the first time #10769
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The e-commerce demo was rendering a blank page with many redirects to the logout page when loading the page for the first time. After a many seconds, the login form would render due to an
history.pushState
abuse.Solution
Delay the store to avoid a race condition in
useLogout
that would cause theCoreAdminRoutes
component to rerender theLogoutOnMount
component leading to an infinite loop.How To Test
Start the e-commerce demo with the following command:
The login page should load fast and no warning about
history.pushState
should be seen in the console.Additional Checks
master
for a bugfix or a documentation fix, ornext
for a featureAlso, please make sure to read the contributing guidelines.