Skip to content

ci: exercise examples to validate on CI #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chickenandpork
Copy link
Contributor

This PR adds to the PR CI so that after the basic test runs, the examples are also run.

  • as commented in CI, a single directory is not suitable for rules_bazel_integration_tests
  • even so, since rules_bazel_integration_tests is sequential, I'd prefer to run them through a marix so that examples build In parallel but dependent on the basic test's successful completion
  • .bazelignore keeps the examples entry: the cd examples in CI causes the //.bazelignore to be ineffective

This would have caught the issue in #98 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant