Skip to content

[Catalog] Remove Multidex #4637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Catalog] Remove Multidex #4637

wants to merge 2 commits into from

Conversation

MGaetan89
Copy link
Contributor

With the minSdk being 21 now, Multidex is not needed anymore.
See https://developer.android.com/build/multidex#mdex-on-l

I've also removed some unnecessary SDK version checks. Let me know if these should be in a dedicated PR.

@drchen drchen added the Reviewing Internally An internal change has been created and sent for review. label Mar 5, 2025
@MGaetan89
Copy link
Contributor Author

I've updated the PR to fix the conflicts caused by 4662301

@MGaetan89 MGaetan89 force-pushed the remove_multidex branch 2 times, most recently from 3816e0d to bcc2343 Compare May 12, 2025 19:15
@MGaetan89
Copy link
Contributor Author

@drchen any progress on the internal review?

@MGaetan89
Copy link
Contributor Author

I've updated the PR to fix the conflict

@MGaetan89
Copy link
Contributor Author

@drchen I've updated the PR to fix the conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drchen drchen drchen approved these changes

Assignees
No one assigned
Labels
Reviewing Internally An internal change has been created and sent for review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGaetan89 @drchen