Adding negative tests for partial read workflow #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
=======================================
Coverage 97.11% 97.11%
=======================================
Files 8 8
Lines 243 243
=======================================
Hits 236 236
Misses 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
krisfed
reviewed
Jul 14, 2025
|
|
||
| %TODO: negative values, wrong datatypes, out of bounds | ||
|
|
||
| wrongDims = [1,1,1]; |
There was a problem hiding this comment.
Maybe add a comment here that the number of dimensions is wrong? I understand making the variable name shorter, but without that information it can be hard to quickly figure out what is "wrong" about these dimensions.
krisfed
reviewed
Jul 14, 2025
| inpVal = [100 200]; | ||
| errID = 'MATLAB:Python:PyException'; | ||
| testcase.verifyError(@()zarrread(zpath,"Start",inpVal),errID); | ||
| %testcase.verifyError(@()zarrread(zpath,"Stride",inpVal),errID); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the todo items for using negative inputs with partial read workflows.