CI: Harden GHA configuration #104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eliminates the possibility of a tag being changed under us.
This eliminates the possibility of a tag being changed under us.
May include: - Avoids risky string interpolation. - Prevents checkout premissions from leaking
Reduces risk of arbitrary code is run by attacker.
QuLogic
reviewed
Jul 22, 2025
| @@ -27,15 +27,19 @@ jobs: | |||
| name: Post warnings/errors as review | |||
| steps: | |||
| - uses: actions/checkout@v3 | |||
There was a problem hiding this comment.
Not pinning this one to a commit?
| @@ -14,6 +16,7 @@ jobs: | |||
| - uses: actions/checkout@v4 | |||
There was a problem hiding this comment.
None of the actions are pinned to commit in this file.
.github/workflows/reviewdog.yml
Outdated
There was a problem hiding this comment.
None of the actions are pinned to commits here.
Co-authored-by: Elliott Sales de Andrade <[email protected]>
|
The tool I used to ID what needed to be pinned (zizmor) does not flag actions/XYZ. |
QuLogic
reviewed
Aug 13, 2025
Comment on lines
+3
to
+4
| permissions: | ||
| contents: read |
There was a problem hiding this comment.
reviewdog needs write permissions for checks (cf Matplotlib's linting.yml.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply recommended hardening steps including: