Skip to content

chore: footer cleanup #2869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

pReya
Copy link

@pReya pReya commented Aug 10, 2025

I've reworked some minor things about the footer:

  • Update all icons (clean up unnecessary markup in the SVG, resize all icons to be centered in their square 24px container, use currentColor)
  • Inline icons (to be able to use currentColor)
  • Update Twitter to X icon
  • Fix noisy alignment of "internal-links" section (use a 3 col grid instead)
  • Allow "newTab" and "relMe" props in toml
  • Open all external links in new Tab
  • Move ALL footer links to the toml file
  • Move footer styles to their own _footer.scss file

Before:
Screenshot 2025-08-10 at 10 05 31

After:
Screenshot 2025-08-10 at 10 05 40

✔️ Checklist

  • Check for common mistakes:
    • Wrap plain URLs in <> to linkify them (learn more).
    • Use the right level of headings: The page title will use a level 1 headings, so your headings should use level 2 and below.
    • Use internal links: when linking to another page on https://matrix.org, use the Zola [label](@/target.md) syntax.
  • For blog posts:
    • Verify the date and post ordering on the /blog page, especially for multiple posts on the same day. Prefer UTC format, e.g. 2025-12-01T14:00:00Z for Dec 1st, 2025, 2pm UTC.
    • Set the correct author and category. Browse existing ones at https://matrix.org/author/ and https://matrix.org/category/ to match them.
  • Let us know if you are contributing in a specific role, such as on behalf of an organisation or team, for example.
  • Let us know if your PR is time-sensitive in any way.
  • Mention any issues related to the PR. Use GitHub keywords as appropriate.
  • Your individual commits or pull request is signed off.

Signed-off-by: Moritz Stückler <[email protected]>
@HarHarLinks HarHarLinks added enhancement This would be an improvement to the website. aesthetic Visual inconsistencies or improvements labels Aug 10, 2025
Copy link
Collaborator

@HarHarLinks HarHarLinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

we have historically not been doing an excellent job at tracking licenses for the icons, which is why they are missing in the existing files (see #2706, #2776). would you mind adding the license info for the new x.svg in https://reuse.software/ style?

@pReya
Copy link
Author

pReya commented Aug 10, 2025

would you mind adding the license info for the new x.svg in https://reuse.software/ style?

Big Companies typically grant a limited license to use their logos for purposes such as linking to a social media profile. However these are proprietary licenses, which are not part of any SPDX license list. So I'm afraid it's not possible/practical to do this for company logos such as Twitter, YouTube, etc.

The actual source for the logo was the official twitter brand site: https://about.x.com/en/who-we-are/brand-toolkit

@pReya
Copy link
Author

pReya commented Aug 11, 2025

@HarHarLinks Not sure if you saw my comment without tagging you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aesthetic Visual inconsistencies or improvements enhancement This would be an improvement to the website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants