Skip to content

Raspberry pi distros no longer have /opt/vc, use GBM instead #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

marc-weber1
Copy link

No description provided.

Copy link
Owner

@matusnovak matusnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work. Just one nit. I will test it out on my Raspberry Pi 4 first.

{
fprintf(stderr, "Failed to open file triangle.raw for writing!\n");
}
int success = stbi_write_png("triangle.png", desiredWidth, desiredHeight, 3, buffer, desiredWidth * 3);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small nit, you are not using the success result.

Could you add something like the following after?

if (success != 1) {
    fprintf(stderr, "Failed to open file triangle.png for writing!\n");
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants