-
Notifications
You must be signed in to change notification settings - Fork 37
docs: updated documentation for Configuration component. #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there @Teebarh thanks for working on this.
There are a lot of Vale issues which need resolving.
Also, please ensure you fix the headings to use the correct length - they must be exactly the same as the text they underline.
Finally, please remove all links. You should be using the :doc: reference for linking to headings, or :ref: on the same page, or using the command make link
for external links.
docs/plugins/config.rst
Outdated
============= | ||
|
||
The form type is used to generate the form fields in the main configuration form. See the `Forms documentation <https://devdocs.mautic.org/en/latest/components/forms.html>`_ for more information about using form types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The form type is used to generate the form fields in the main configuration form. See the `Forms documentation <https://devdocs.mautic.org/en/latest/components/forms.html>`_ for more information about using form types. | |
The form type is used to generate the fields in the main configuration form. See the `Forms documentation <https://devdocs.mautic.org/en/latest/components/forms.html>`_ for more information about using form types. |
Please also fix the link. See earlier comments.
Hi @RCheesley! I've made the changes in this commit here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this builds I noticed the route definitions table extends beyond the edge of the page, I think @favour-chibueze might know how to fix this? If so can we address it in this PR?
Otherwise it looks good, thanks @Teebarh for the work on this!
Thank you! It was a pleasure working on it. |
This pull request migrates over the documentation for the Configuration component in the reStructuredText (RST) format. It addresses Issue #60.