Skip to content

docs: updated documentation for Configuration component. #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: 5.x
Choose a base branch
from

Conversation

Teebarh
Copy link

@Teebarh Teebarh commented Apr 13, 2025

This pull request migrates over the documentation for the Configuration component in the reStructuredText (RST) format. It addresses Issue #60.

@Teebarh Teebarh closed this Apr 15, 2025
@Teebarh Teebarh reopened this Apr 22, 2025
@RCheesley RCheesley self-requested a review April 23, 2025 14:26
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @Teebarh thanks for working on this.

There are a lot of Vale issues which need resolving.

Also, please ensure you fix the headings to use the correct length - they must be exactly the same as the text they underline.

Finally, please remove all links. You should be using the :doc: reference for linking to headings, or :ref: on the same page, or using the command make link for external links.

=============

The form type is used to generate the form fields in the main configuration form. See the `Forms documentation <https://devdocs.mautic.org/en/latest/components/forms.html>`_ for more information about using form types.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The form type is used to generate the form fields in the main configuration form. See the `Forms documentation <https://devdocs.mautic.org/en/latest/components/forms.html>`_ for more information about using form types.
The form type is used to generate the fields in the main configuration form. See the `Forms documentation <https://devdocs.mautic.org/en/latest/components/forms.html>`_ for more information about using form types.

Please also fix the link. See earlier comments.

@Teebarh
Copy link
Author

Teebarh commented Apr 27, 2025

Hi there @Teebarh thanks for working on this.

There are a lot of Vale issues which need resolving.

Also, please ensure you fix the headings to use the correct length - they must be exactly the same as the text they underline.

Finally, please remove all links. You should be using the :doc: reference for linking to headings, or :ref: on the same page, or using the command make link for external links.

Hi @RCheesley! I've made the changes in this commit here.

@favour-chibueze favour-chibueze added the writetechhub Pull requests from writetechhub's team label May 2, 2025
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this builds I noticed the route definitions table extends beyond the edge of the page, I think @favour-chibueze might know how to fix this? If so can we address it in this PR?

image

Otherwise it looks good, thanks @Teebarh for the work on this!

@Teebarh
Copy link
Author

Teebarh commented May 8, 2025

When this builds I noticed the route definitions table extends beyond the edge of the page, I think @favour-chibueze might know how to fix this? If so can we address it in this PR?

image

Otherwise it looks good, thanks @Teebarh for the work on this!

Thank you! It was a pleasure working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
writetechhub Pull requests from writetechhub's team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants