Show airframe ID as vehicle name if vehicle name is not known #13240
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the vehicle airframe details aren't stored in QGC's
AirframeFactMetaData.xml
file, the Vehicle name is left blank. It would be more informative to show the airframe ID when the vehicle name isn't known.ex.
Without the changes in this PR, If you use the PX4 SIH sim
you see

with the changes in this PR, you will now see

10040
as the vehicle name. This is the airframe ID. A developer who knows about airframe IDs will know the meta data for the vehicle can be manually viewed in the airframe file, in this casePX4-Autopilot/ROMFS/px4fmu_common/init.d-posix/airframes/10040_sihsim_quadx
The vehicle name still shows the normal stuff if the vehicle has a known airframe id. For example, if you run
The changes in this PR do not change how it displays the recognized vehicle's metadata
