Skip to content

Update Caching in Progressive Web Apps guides #39908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025
Merged

Conversation

denmch
Copy link
Contributor

@denmch denmch commented Jun 12, 2025

Description

Fixes #39769 by defining url in the second code block, which would cause a reference error as it was not declared.

Motivation

To close issue #39769.

Additional details

N/A

Related issues and pull requests

#39769

Fixes mdn#39769 by defining url in the second code block.
@denmch denmch requested a review from a team as a code owner June 12, 2025 01:14
@denmch denmch requested review from chrisdavidmills and removed request for a team June 12, 2025 01:14
@github-actions github-actions bot added the Content:PWA Progressive Web Apps content label Jun 12, 2025
@github-actions github-actions bot added the size/xs [PR only] 0-5 LoC changed label Jun 12, 2025
Copy link
Contributor

github-actions bot commented Jun 12, 2025

Preview URLs

(comment last updated: 2025-06-12 01:17:02)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks @denmch!

@chrisdavidmills chrisdavidmills merged commit 505b41b into mdn:main Jun 12, 2025
8 checks passed
@denmch denmch deleted the patch-2 branch June 13, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:PWA Progressive Web Apps content size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

url is not defined in the 2nd code block
2 participants