-
Notifications
You must be signed in to change notification settings - Fork 65
Upgrade readme & changelog to reflect change from requestConfig to requestInit #1399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughThe documentation for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🔭 Outside diff range comments (1)
packages/instant-meilisearch/README.md (1)
241-247
: Call out thatsignal
is no longer supported and tighten wordingGreat example. Two small improvements:
- Mention that
signal
is not supported anymore withrequestInit
(as of meilisearch-js v0.50.0).- Minor grammar: “Available fields can be found here.”
Suggested additions (outside the selected range, near the paragraph above the snippet):
You can provide a custom request configuration. Available fields can be [found here](https://fetch.spec.whatwg.org/#requestinit). Note: as of Meilisearch JS v0.50.0, `signal` is not supported in `requestInit`. If you need request cancellation, consider handling it in your custom `httpClient`.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/instant-meilisearch/CHANGELOG.md
(1 hunks)packages/instant-meilisearch/README.md
(2 hunks)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @jeremylynch and thanks for your first contribution in this repository 🙌
In Meilisearch v0.50.0:
Details here: https://github.com/meilisearch/meilisearch-js/releases
This package needs to update readme
Summary by CodeRabbit