Skip to content

Fix deprecated defaultProps error warning #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tristanheilman
Copy link

  • upgraded to work with react native 0.75.5
  • tested locally with react native 0.75.5
  • upgraded to typescript v5
  • fixed linting error

Checks

Description

Below is a public repository that provides a simple test on a barebones React Native 0.75.5 project. v1.0.0 shows the error that this issue describes. v2.0.0 shows the provided patch and passing tests.

https://github.com/tristanheilman/react-native-render-html-684-test/releases

NOTE: There was one item that I didn't spend time figuring out and that was the website portion of this repository. I was getting errors with the rdocusaurus-plugin-sass repository due it using a git branch checkout. I was unable to run yarn install until providing a valid repository version.

Fixes issue #684

- upgraded to work with react native 0.75.5
- tested locally with react native 0.75.5
- upgraded to typescript v5
- fixed linting error
@besouro7
Copy link

Any updates on this?

@dev-sulav
Copy link

Why no updates on this? Any patch or suggestion to do if the update is not coming soon?

@JustinKubicz
Copy link

BUMP

@paul7aa
Copy link

paul7aa commented Jun 24, 2025

+1 bump

@tristanheilman
Copy link
Author

Why no updates on this? Any patch or suggestion to do if the update is not coming soon?

A patch file is provided in the test repository that I shared. It can be found at this link:
https://github.com/tristanheilman/react-native-render-html-684-test/blob/main/.yarn/patches/react-native-render-html-npm-6.3.4-35624feabf.patch

I'm unsure if yarn will allow you to straight copy over the patch file into your .yarn/patches folder. You may need to follow the below steps to patch from scratch.

To patch the library temporarily, you can follow the below steps:

  1. Clone the https://github.com/tristanheilman/react-native-render-html-684-test repository
  2. Run yarn install
  • You will utilize the node_modules/react-native-render-html folder later
  1. Install the react-native-render-html library in your main project using yarn
  2. Run yarn patch react-native-render-html
➤ YN0000: Package react-native-render-html@npm:6.3.4 got extracted with success!
➤ YN0000: You can now edit the following folder: /private/var/folders/_q/5t99hgx90cg4_4hjs5fg0gsr0000gn/T/xfs-682b0fea/user
➤ YN0000: Once you are done run yarn patch-commit -s /private/var/folders/_q/5t99hgx90cg4_4hjs5fg0gsr0000gn/T/xfs-682b0fea/user and Yarn will store a patchfile based on your changes.
➤ YN0000: Done in 0s 121ms
  1. Navigate to the folder that yarn has created to edit the contents of the library
  2. Copy over the contents of the node_modules/react-native-render-html project from the 684-test repository into the yarn private folder and replace everything that is a duplicate
  3. Run yarn patch-commit -s {folderName}

The patch file should be created and stored in your .yarn/patches folder. You can compare it to the patch file created in the 684-test repository to confirm.

@dlujan
Copy link

dlujan commented Jun 25, 2025

Any plans to merge this soon??? This error is getting annoying.

@ThiaAlves
Copy link

When will this fix be merged?

@carlosascastro
Copy link

This is now a P0 since it become an error on Expo 52 (React Native 0.76.* and Android sdk 34 target) and Google policies requires apps to be update to Android sdk 35 till August 31th.

@palicko
Copy link

palicko commented Aug 12, 2025

Hey,
for anyone who don't want to go through all steps @tristanheilman mentions.
This is his patch file you can put directly in /patches folder and just use patch-package.
react-native-render-html+6.3.4.patch

@olegmilan
Copy link

Hey, for whom patch form @palicko doesn't work, please try mine:
react-native-render-html+6.3.4.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.