Made message sizes consistent, updated BW calculations #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Communications benchmarks typically give the user control over message sizes, to better illuminate crossover points in software and hardware performance. Several of the collective benchmarks were using message sizes of numproccountsizeof(float) bytes. For consistency with other tools and benchmarkers' expectations, I changed those to use message sizes of count*sizeof(float) bytes.
Some bandwidth calculations were also incorrect (and I made some incorrect by the above change), so those are adjusted. For example, during an alltoall each rank sends (numprocs-1) messages, but during an allreduce there are 2*(numprocs-1) total messages sent.
Finally, I updated the Frontier Makefile to use the rccl and mpich_gtl libraries to support GPU-aware MPI.
With these changes, CommBench roughly recreates the performance of https://github.com/ROCm/rccl-tests.