-
Notifications
You must be signed in to change notification settings - Fork 34
Simplify Gradle build logic for making releases. #700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Release and release candidate builds require a clean working directory and a matching tag: Create a tag for the release version first, then execute whatever build target you need with the corresponding version specified as project property (`-PpublishVersion=A.B.C` or `-PpublishVersion=A.B.C-rcN`). Release builds additionally enforce signing of the generated artifacts. Ad hoc builds from branches (including `master`) or arbitrary "version" designators always result in SNAPSHOT builds and don't require a clean working directory or a matching tag: Specify the desired "version" as project property (`-PpublishVersion=A-B-C-SNAPSHOT`) or simply omit it (will then use the current branch name).
dfee37c
to
ab7f368
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides he empty line I think this is good 👍
@blackwinter can you help me how to review this? what should I try to run? |
First of all, you should review the updated steps in Then you could run various scenarios (without actually pushing/publishing anything!). Different branches/detached head, different If you need more guidance we should meet for a "review session". |
In order to minimize risk of injection attacks.
Resolves #684.
Release and release candidate builds require a clean working directory and a matching tag: Create a tag for the release version first, then execute whatever build target you need with the corresponding version specified as project property (
-PpublishVersion=A.B.C
or-PpublishVersion=A.B.C-rcN
). Release builds additionally enforce signing of the generated artifacts.Ad hoc builds from branches (including
master
) or arbitrary "version" designators always result in SNAPSHOT builds and don't require a clean working directory or a matching tag: Specify the desired "version" as project property (-PpublishVersion=A-B-C-SNAPSHOT
) or simply omit it (will then use the current branch name).Behavioural changes:
releases/*
for release builds and*-rc*
for release candidates).