Skip to content

Update README and Makefile #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 16, 2024
Merged

Update README and Makefile #2

merged 12 commits into from
Jul 16, 2024

Conversation

michplunkett
Copy link
Owner

@michplunkett michplunkett commented Jul 16, 2024

Describe your changes

Added missing information to README and a missing command to the Makefile.

Checklist before requesting a review

  • The code runs successfully.
michaelp@MacBook-Air-18 golang-scripting % ls
LICENSE		Makefile	README.md	cmd		go.mod		go.sum
michaelp@MacBook-Air-18 golang-scripting % make parse-slack-data
go run ./cmd/slackMessageParser/main.go
2024/07/16 00:08:50 the ./SlackMessages directory does not exist
exit status 1
make: *** [parse-slack-data] Error 1
michaelp@MacBook-Air-18 golang-scripting % mkdir -p ./SlackMessages
michaelp@MacBook-Air-18 golang-scripting % make parse-slack-data
go run ./cmd/slackMessageParser/main.go
2024/07/16 00:11:16 could not find *.json files in the ./SlackMessages directory
exit status 1
michaelp@MacBook-Air-18 golang-scripting % cp ~/Downloads/Archive/* ./SlackMessages
michaelp@MacBook-Air-18 golang-scripting % make parse-slack-data
go run ./cmd/slackMessageParser/main.go
michaelp@MacBook-Air-18 golang-scripting % ls
LICENSE			Makefile		README.md		SlackMessages		cmd			go.mod			go.sum			slack_records.csv
michaelp@MacBook-Air-18 golang-scripting %

@michplunkett michplunkett self-assigned this Jul 16, 2024
@michplunkett michplunkett marked this pull request as ready for review July 16, 2024 05:18
@michplunkett michplunkett merged commit cbcaa04 into main Jul 16, 2024
1 check passed
@michplunkett michplunkett deleted the add-instructions branch July 16, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant