Official API Review for Microsoft.Windows.Storage.Pickers #5634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inahK-2SO/storage_pickers_official_API_review
kmahone
reviewed
Jul 23, 2025
oldnewthing
reviewed
Jul 23, 2025
oldnewthing
reviewed
Jul 23, 2025
Scottj1s
reviewed
Jul 24, 2025
Scottj1s
reviewed
Jul 24, 2025
Scottj1s
reviewed
Jul 24, 2025
Scottj1s
reviewed
Jul 24, 2025
Scottj1s
reviewed
Jul 24, 2025
codendone
reviewed
Jul 24, 2025
DinahK-2SO
force-pushed
the
user/DinahK-2SO/storage_pickers_official_API_review
branch
from
73a70d3 to
3e36324
Compare
DinahK-2SO
added a commit
that referenced
this pull request
Jul 25, 2025
This PR implements suggestions raised in the official API review of `Microsoft.Windows.Storage.Pickers` APIs (#5634 ). 1. Removal of `SettingsIdentifier` Property. 2. Replace method `TrySetSuggestedSaveFilePath` with the property's own setter. 3. For FileSavePicker, updated underlying logic to ensure that the file name in `SuggestedSaveFilePath` takes precedence over the `SuggestedFileName`, even if the folder of `SuggestedSaveFilePath` does not exists. This is also the existing behavior of UWP pickers ( the `Windows.Storage.Pickers`) 4. Test Additions and Updates. 5. XML and Feature Flag Cleanup.
DinahK-2SO
added a commit
that referenced
this pull request
Jul 25, 2025
This PR implements suggestions raised in the official API review of `Microsoft.Windows.Storage.Pickers` APIs (#5634 ). 1. Removal of `SettingsIdentifier` Property. 2. Replace method `TrySetSuggestedSaveFilePath` with the property's own setter. 3. For FileSavePicker, updated underlying logic to ensure that the file name in `SuggestedSaveFilePath` takes precedence over the `SuggestedFileName`, even if the folder of `SuggestedSaveFilePath` does not exists. This is also the existing behavior of UWP pickers ( the `Windows.Storage.Pickers`) 4. Test Additions and Updates. 5. XML and Feature Flag Cleanup.
LegendaryBlair
pushed a commit
that referenced
this pull request
Jul 25, 2025
This PR implements suggestions raised in the official API review of `Microsoft.Windows.Storage.Pickers` APIs (#5634 ). 1. Removal of `SettingsIdentifier` Property. 2. Replace method `TrySetSuggestedSaveFilePath` with the property's own setter. 3. For FileSavePicker, updated underlying logic to ensure that the file name in `SuggestedSaveFilePath` takes precedence over the `SuggestedFileName`, even if the folder of `SuggestedSaveFilePath` does not exists. This is also the existing behavior of UWP pickers ( the `Windows.Storage.Pickers`) 4. Test Additions and Updates. 5. XML and Feature Flag Cleanup.
This was referenced Jul 29, 2025
DinahK-2SO
added a commit
that referenced
this pull request
Jul 29, 2025
DinahK-2SO
added a commit
that referenced
this pull request
Jul 29, 2025
There's an open question regarding the design of SuggestedSaveFilePath during the official API review #5634 Hence hiding this property from preview release.
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
DinahK-2SO
deleted the
user/DinahK-2SO/storage_pickers_official_API_review
branch
DinahK-2SO
added a commit
that referenced
this pull request
Aug 3, 2025
* create the files for official API review * add spec notes for official review * update doc * add details; graceful * update the specs * Resolve comments; Fix typos and grammer errors in doc. * FileSavePicker.SuggestedFolder
LegendaryBlair
pushed a commit
that referenced
this pull request
Aug 3, 2025
…ge.Pickers to 1.8-stable (#5676) * FileSavePicker.SuggestedFolder (#5669) * SuggestedFolder * update tests * Official API Review for Microsoft.Windows.Storage.Pickers (#5634) * create the files for official API review * add spec notes for official review * update doc * add details; graceful * update the specs * Resolve comments; Fix typos and grammer errors in doc. * FileSavePicker.SuggestedFolder * remove old specs
|
How is there a whole review process and no mention of the fact that you can't use pickers in AppContainers? All comments from community (in previous PRs) and all the existing issues about pickers get ignored in creating this spec? App developers that want to distribute to end users with reasonable security need to wait another 5 years for a V3 spec? @DinahK-2SO @oldnewthing @kmahone @codendone @yeelam-gordon @Scottj1s |
DinahK-2SO
added a commit
that referenced
this pull request
Aug 4, 2025
The official spec has been merged via * #5634 This PR removes the unofficial spec.
Hi @charlesroddie , thanks for highlighting this important topic! This spec primarily targets enabling picker functionality when running in elevated mode (i.e., as administrator). While AppContainer scenarios are not in the scope of this spec, I deeply appreciate your interest and enthusiasm. The new pickers support containerized AppContainer with win32-isolation, which is also in preview. Please stay tuned for future updates as we continue to expand storage picker capabilities. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains all design specs of the
Microsoft.Windows.Storage.PickersAPI set.Please start with
specs/Storage.Pickers/Microsoft.Windows.Storage.Pickers.mdNote:
This PR is created for the official API review of
Microsoft.Windows.Storage.PickersAPI set.Since there're some documents on the main branch already, the files are copied from dev/Interop/StoragePickers and updated for official review.
After the review is completed, we will remove dev/Interop/StoragePickers and check in this officially reviewed version.