Skip to content

[General] A11y - Fix certain controls not adapting text spacing (#3692) #3706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 24, 2025

Conversation

MarvinKlein1508
Copy link
Contributor

@MarvinKlein1508 MarvinKlein1508 commented Apr 17, 2025

Pull Request

πŸ“– Description

FluentButton hasn't been adopting text spacing correctly. This PR fixes this.

Before:
before

After:
after

🎫 Issues

Fixes #3692

βœ… Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

@MarvinKlein1508 MarvinKlein1508 changed the title Fix FluentButton not adapting text spacing (#3692) [FluentButton][a11y] Fix FluentButton not adapting text spacing (#3692) Apr 17, 2025
@dvoituron
Copy link
Collaborator

Awesome ;-)
Can you quicky verify if the new web component are already compatible? :-)
https://fluentui-blazor-v5.azurewebsites.net/Button/Button

@MarvinKlein1508
Copy link
Contributor Author

Awesome ;-) Can you quicky verify if the new web component are already compatible? :-) https://fluentui-blazor-v5.azurewebsites.net/Button/Button

v5 is already working for me :)

@MarvinKlein1508 MarvinKlein1508 changed the title [FluentButton][a11y] Fix FluentButton not adapting text spacing (#3692) [a11y] Fix certain controls not adapting text spacing (#3692) Apr 17, 2025
@MarvinKlein1508
Copy link
Contributor Author

MarvinKlein1508 commented Apr 17, 2025

Alright I have gone through all form components and tested / fixed this. This PR addresses this for

  • FluentButton
  • FluentTextArea
  • FluentTextField
  • FluentSearch
  • FluentCombobox
  • FluentNumberField

In v5 this needs to be adapted for TextInput and TextArea

@dvoituron
Copy link
Collaborator

In v5 this needs to be adapted for TextInput and TextArea

What do you mean by "In v5 this needs to be adapted for TextInput and TextArea"?
If this is not A11Y compliant, we need to give this feedback to the Web Component team

@MarvinKlein1508
Copy link
Contributor Author

@dvoituron
v4 after PR:
grafik

v5
grafik

@vnbaaij vnbaaij enabled auto-merge (squash) April 19, 2025 13:42
@vnbaaij vnbaaij requested a review from dvoituron April 24, 2025 06:37
@vnbaaij vnbaaij merged commit 3e25fca into microsoft:dev Apr 24, 2025
4 checks passed
@MarvinKlein1508 MarvinKlein1508 deleted the fix-3692 branch April 24, 2025 06:57
@vnbaaij vnbaaij added this to the v4.11.9 milestone May 4, 2025
@vnbaaij vnbaaij changed the title [a11y] Fix certain controls not adapting text spacing (#3692) [General] A11y - Fix certain controls not adapting text spacing (#3692) May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"OK" and "Cancel" buttons present in the dialog is not adopting the Text Spacing
3 participants