Use Qdrant.Client for QdrantMemory internals #1068
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates QdrantMemory to use the official Qdrant client for QdrantMemory internals. The official client uses gRPC rather than JSON over REST, with gRPC typically offering a significant overall performance improvement.
russcam
commented
May 26, 2025
| QdrantPoint<DefaultQdrantPayload>? existingPoint = await this._qdrantClient | ||
| .GetVectorByPayloadIdAsync(index, record.Id, cancellationToken: cancellationToken) | ||
| IReadOnlyList<RetrievedPoint> existingPoints = await this._qdrantClient | ||
| .RetrieveAsync(index, new Guid(record.Id), cancellationToken: cancellationToken) |
There was a problem hiding this comment.
Merged qdrant/qdrant-dotnet#93 to make this more ergonomic
russcam
commented
May 26, 2025
| this._log.LogTrace("Point ID {0} found, deleting...", existingPoint.Id); | ||
| await this._qdrantClient.DeleteVectorsAsync(index, [existingPoint.Id], cancellationToken).ConfigureAwait(false); | ||
| await this._qdrantClient.DeleteAsync(index, new Guid(existingPoint.Id.Uuid), cancellationToken: cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
Merged qdrant/qdrant-dotnet#93 to make this more ergonomic
russcam
commented
May 26, 2025
| { | ||
| [Id] = record.Id, | ||
| [Tags] = record.Tags.Pairs.Select(tag => $"{tag.Key}{Constants.ReservedEqualsChar}{tag.Value}").ToArray(), | ||
| [Payload] = Value.Parser.ParseJson(JsonSerializer.Serialize(record.Payload, QdrantConfig.JSONOptions)), |
There was a problem hiding this comment.
Can implement an IDictionary<string, object> -> Struct method over this serialize/deserialize (to later serialize again) approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates QdrantMemory to use the official Qdrant client for QdrantMemory internals.
I wanted to open a PR at this stage to gauge interest in this change. Further work needed to remove the current client implementation and to test adapters between Kernel memory and Qdrant client is needed.
Motivation and Context (Why the change? What's the scenario?)
High level description (Approach, Design)
MemoryRecordto Qdrant types. There may be opportunities to make this smoother.