Fixing ABM DEP check bug #206
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@burrrble: Thanks, This was great catch! I also fixed this too on few other scripts as well. |
CKunze-MSFT
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This statement results in the script failing.
if [ ! $? == 0 ]; then echo "$(date) | This device is not ABM managed" exit 0; elseBecause of the single brackets, ZSH is invoking the history expansion operator
!instead of performing negation on the exit code check$? == 0Using the double brackets fixes the problem and the script runs fine:
if [[ ! $? == 0 ]]; then echo "$(date) | This device is not ABM managed" exit 0; elseDouble brackets aren't POSIX compliant, but I don't think it matters for this particular script?