-
Notifications
You must be signed in to change notification settings - Fork 17
Add test case for mlc doc script detect-os #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
I’ve signed and submitted the CLA, just waiting for approval. Let me know if anything else is needed from my side! |
Hey @shahfarazz , thanks for dropping a PR. Just wanted to ask how are we running the test. We usually have GitHub action workflow files for these tests, one such examples would be found here. @arjunsuresh should we add the test for Edit: I see that these tests would be useful if we include it in both |
Thanks, @anandhu-eng! At the moment, I’ve just run the test locally with pytest to validate functionality. Once the CLA is cleared and I get confirmation on where to place the workflow (either here or in mlcflow), I’ll proceed to set up the GitHub Action accordingly. Appreciate the feedback! |
@anandhu-eng yes, we can place the github action in both the repos. May be in the doc action, we can return a key |
recheck |
Hi, I received email confirmation this morning at 5:37 AM Central Time from Liz Walker that my CLA submission was approved. It still hasn’t updated on GitHub, so I’m waiting for that to reflect. Let me know if there’s anything else needed from my end! Thanks, |
Hi @shahfarazz thanks for your PR. The CLA approval shouldn't have taken more than a couple of days. It seems your github user is still not approved. But adding a test for https://github.com/mlcommons/mlperf-automations/blob/main/.github/workflows/document-scripts.yml |
This PR adds a basic test case for the mlc doc script command targeting the detect-os script. It checks if the README.md is correctly generated.
📌 Notes
The test checks for successful execution and file presence.
Verified locally using pytest.
Let me know if you'd like help improving or customizing this further!