Remove some measures, update some others #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mb706
commented
Apr 17, 2025
mb706
commented
- Remove a few measures that are superseded by mlr3::MeasureRegrRSQ.
- Add sample_weights for sse, sae
- Small docs changes.
There was a problem hiding this comment.
Pull Request Overview
This PR removes several measures in favor of mlr3::MeasureRegrRSQ, adds sample_weights for sse and sae measures, and updates documentation accordingly.
- Removes the deprecated measures rse, rsq, rrse, and rae.
- Documents these changes and introduces sample_weights for sse and sae in NEWS.md and other relevant parts.
Files not reviewed (19)
- DESCRIPTION: Language not supported
- NAMESPACE: Language not supported
- R/classif_acc.R: Language not supported
- R/helper.R: Language not supported
- R/regr_rae.R: Language not supported
- R/regr_rrse.R: Language not supported
- R/regr_rse.R: Language not supported
- R/regr_rsq.R: Language not supported
- R/regr_sae.R: Language not supported
- R/regr_sse.R: Language not supported
- man/acc.Rd: Language not supported
- man/ae.Rd: Language not supported
- man/ape.Rd: Language not supported
- man/bias.Rd: Language not supported
- man/ktau.Rd: Language not supported
- man/linex.Rd: Language not supported
- man/mae.Rd: Language not supported
- man/mape.Rd: Language not supported
- man/maxae.Rd: Language not supported
Co-authored-by: Copilot <[email protected]>
|
Should not be merged before mlr-org/mlr3#1124 , since mlr3 still depends on the measures being removed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.