Rename ResourceReference to ResourceTemplateReference #947
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Those are breaking changes - fyi |
@Kludex , have type alias for this in case anyone is using it directly, any other use case is missing? |
ah, then sorry, all good. |
thanks for checking!! |
Kludex
requested changes
Jun 13, 2025
src/mcp/types.py
Outdated
Comment on lines
965
to
966
| # Deprecated: Use ResourceTemplateReference instead | ||
| ResourceReference = ResourceTemplateReference |
There was a problem hiding this comment.
You want something like this:
Suggested change
| # Deprecated: Use ResourceTemplateReference instead | |
| ResourceReference = ResourceTemplateReference | |
| @deprecated("`ResourceReference` is deprecated, you should use `ResourceTemplateReference`.") | |
| class ResourceReference(ResourceTemplateReference): | |
| """A reference to a resource or resource template definition.""" |
Kludex
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #916
Details in modelcontextprotocol/modelcontextprotocol#639