refactor: Fixing some code smells AISS IS3-L5-5

app/Exceptions/UnknownPermissionException.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace App\Exceptions;
+
+use Exception;
+
+class UnknownPermissionException extends Exception
+{
+    public function __construct($message = "Unknown permission", $code = 400)
+    {
+        parent::__construct($message, $code);
+    }
+}

app/Http/Middleware/AuthenticateWithTokenOnBasicAuth.php

@@ -79,9 +79,7 @@ private function sanctumUser(Request $request): ?User
     protected function sanctum(): RequestGuard
     {
         /** @var \Illuminate\Auth\RequestGuard */
-        $guard = $this->auth->guard('sanctum');
-
-        return $guard;
+        return $this->auth->guard('sanctum');
     }
 
     /**

app/Http/Middleware/SanctumSetUser.php

@@ -37,8 +37,6 @@ public function handle(Request $request, Closure $next)
     protected function sanctum(): RequestGuard
     {
         /** @var \Illuminate\Auth\RequestGuard */
-        $guard = $this->auth->guard('sanctum');
-
-        return $guard;
+        return $this->auth->guard('sanctum');
     }
 }

app/Services/BaseService.php

@@ -3,6 +3,7 @@
 namespace App\Services;
 
 use App\Exceptions\NotEnoughPermissionException;
+use App\Exceptions\UnknownPermissionException;
 use App\Models\Account;
 use App\Models\Contact;
 use App\Models\Group;
@@ -112,7 +113,7 @@ public function validateRules(array $data): bool
         }
 
         if (($e = $permissions->diff(collect(self::$permissionDependencies)->keys()))->isNotEmpty()) {
-            throw new \Exception('Unknown permission: '.$e->first());
+            throw new UnknownPermissionException('Unknown permission: '.$e->first());
         }
 
         return true;

database/factories/UserFactory.php

@@ -42,11 +42,7 @@ public function definition(): array
      */
     public function unverified()
     {
-        return $this->state(function (array $attributes) {
-            return [
-                'email_verified_at' => null,
-            ];
-        });
+        return $this->state(fn () => ['email_verified_at' => null,]);
     }
 
     /**
@@ -56,10 +52,6 @@ public function unverified()
      */
     public function administrator()
     {
-        return $this->state(function (array $attributes) {
-            return [
-                'is_account_administrator' => true,
-            ];
-        });
+        return $this->state(fn () => ['is_account_administrator' => true]);
     }
 }

resources/js/Components/Label.vue

@@ -1,11 +1,12 @@
 <script setup>
 defineProps({
   value: String,
+  forId: String,
 });
 </script>
 
 <template>
-  <label class="block text-sm font-medium text-gray-700 dark:text-gray-300">
+  <label :for="forId" class="block text-sm font-medium text-gray-700 dark:text-gray-300">
     <span v-if="value">
       {{ value }}
     </span>

resources/js/Pages/Settings/Notifications/Partials/Emails.vue

@@ -310,7 +310,7 @@ export default {
           .delete(channel.url.destroy)
           .then(() => {
             this.flash(this.$t('The email address has been deleted'), 'success');
-            var id = this.localEmails.findIndex((x) => x.id === channel.id);
+            let id = this.localEmails.findIndex((x) => x.id === channel.id);
             this.localEmails.splice(id, 1);
           })
           .catch((error) => {

resources/js/bootstrap.js

@@ -17,14 +17,3 @@ window.axios.defaults.headers.common['X-Requested-With'] = 'XMLHttpRequest';
  * for events that are broadcast by Laravel. Echo and event broadcasting
  * allows your team to easily build robust real-time web applications.
  */
-
-// import Echo from 'laravel-echo';
-
-// window.Pusher = require('pusher-js');
-
-// window.Echo = new Echo({
-//     broadcaster: 'pusher',
-//     key: process.env.MIX_PUSHER_APP_KEY,
-//     cluster: process.env.MIX_PUSHER_APP_CLUSTER,
-//     forceTLS: true
-// });