Skip to content

Add FXIOS-12147 Change ToS card's button string from Agree and continue to just Continue Firefox and Focus #26564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

razvanlitianu
Copy link
Collaborator

@razvanlitianu razvanlitianu commented May 7, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

Use previous translated value, until new string is translated.

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If needed, I updated documentation and added comments to complex code
  • If needed, I added a backport comment (example @Mergifyio backport release/v120)

…tinue to just Continue Firefox and Focus
@razvanlitianu razvanlitianu requested a review from a team as a code owner May 7, 2025 09:25
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 36.21%
📖 Edited 1 files
📖 Created 0 files

Client.app: Coverage: 35.1

File Coverage
TermsOfServiceViewController.swift 81.71%

Generated by 🚫 Danger Swift against 9ad299d

@razvanlitianu razvanlitianu merged commit df7bfc5 into main May 7, 2025
8 checks passed
@razvanlitianu razvanlitianu deleted the rlitianu/FXIOS-12147-#26429-Change-ToS-cards-button-string-from-Agree-and-continue-to-just-Continue-Firefox-and-Focus branch May 7, 2025 11:05
@razvanlitianu razvanlitianu added the weekly-release Tagging backports for rapid release label May 7, 2025
@razvanlitianu
Copy link
Collaborator Author

@Mergifyio backport release/v139

Copy link
Contributor

mergify bot commented May 7, 2025

backport release/v139

✅ Backports have been created

@razvanlitianu
Copy link
Collaborator Author

@Mergifyio backport release/v138

Copy link
Contributor

mergify bot commented May 7, 2025

backport release/v138

✅ Backports have been created

@razvanlitianu razvanlitianu removed the weekly-release Tagging backports for rapid release label May 7, 2025
mergify bot pushed a commit that referenced this pull request May 7, 2025
…ue to just Continue Firefox and Focus (#26564)

FXIOS-12147 #26429 Change ToS card's button string from Agree and continue to just Continue Firefox and Focus

(cherry picked from commit df7bfc5)
mergify bot pushed a commit that referenced this pull request May 7, 2025
…ue to just Continue Firefox and Focus (#26564)

FXIOS-12147 #26429 Change ToS card's button string from Agree and continue to just Continue Firefox and Focus

(cherry picked from commit df7bfc5)

# Conflicts:
#	firefox-ios/Client/Frontend/Onboarding/Views/TermsOfServiceViewController.swift
razvanlitianu added a commit that referenced this pull request May 7, 2025
…ue to just Continue Firefox and Focus (backport #26564) (#26565)

Add FXIOS-12147 Change ToS card's button string from Agree and continue to just Continue Firefox and Focus (#26564)

FXIOS-12147 #26429 Change ToS card's button string from Agree and continue to just Continue Firefox and Focus

(cherry picked from commit df7bfc5)

Co-authored-by: Litianu Razvan <[email protected]>
dsmithpadilla pushed a commit that referenced this pull request May 12, 2025
…ue to just Continue Firefox and Focus (backport #26564) (#26566)

* Add FXIOS-12147 Change ToS card's button string from Agree and continue to just Continue Firefox and Focus (#26564)

FXIOS-12147 #26429 Change ToS card's button string from Agree and continue to just Continue Firefox and Focus

(cherry picked from commit df7bfc5)

# Conflicts:
#	firefox-ios/Client/Frontend/Onboarding/Views/TermsOfServiceViewController.swift

* Fix conflict

---------

Co-authored-by: Litianu Razvan <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants