Skip to content

Add FXIOS-12154 #26444 [Tab tray] trash can telemetry (backport #26584) #26612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 8, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

This is aiming for v139 to add telemetry for the new trash can options under the tab tray

🎥 Screenshot

New trash can options

Simulator Screenshot - iPhone 16 - 2025-05-07 at 11 09 21

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If needed, I updated documentation and added comments to complex code
  • If needed, I added a backport comment (example @Mergifyio backport release/v120)

This is an automatic backport of pull request #26584 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner May 8, 2025 14:39
@mergify mergify bot added the conflicts label May 8, 2025
@mergify mergify bot requested review from thatswinnie and removed request for a team May 8, 2025 14:39
Copy link
Contributor Author

mergify bot commented May 8, 2025

Cherry-pick of 620d70b has failed:

On branch mergify/bp/release/v139/pr-26584
Your branch is up to date with 'origin/release/v139'.

You are currently cherry-picking commit 620d70bc4.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   firefox-ios/Client/Frontend/Browser/Tabs/Middleware/TabManagerMiddleware.swift
	modified:   firefox-ios/Client/TabManagement/TabManager.swift

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   firefox-ios/Client/Telemetry/TabsPanelTelemetry.swift
	both modified:   firefox-ios/Client/metrics.yaml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@lmarceau lmarceau requested review from lmarceau and removed request for thatswinnie May 8, 2025 14:58
@lmarceau
Copy link
Contributor

lmarceau commented May 8, 2025

This depends on another PR before we can merge

Copy link
Contributor Author

mergify bot commented May 12, 2025

This pull request has conflicts when rebasing. Could you fix it @mergify[bot]? 🙏

* WIP need the other PR to continue

* Add telemetry

* Fix PR number

* Fix event with comment

(cherry picked from commit 620d70b)

# Conflicts:
#	firefox-ios/Client/Telemetry/TabsPanelTelemetry.swift
#	firefox-ios/Client/metrics.yaml
@lmarceau lmarceau force-pushed the mergify/bp/release/v139/pr-26584 branch from 96a47d0 to 9ebce12 Compare May 12, 2025 15:46
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 36.44%
📖 Edited 4 files
📖 Created 0 files

Client.app: Coverage: 35.12

File Coverage
TabManagerMiddleware.swift 16.32% ⚠️
TabManager.swift 60.0%
TabsPanelTelemetry.swift 15.09% ⚠️

Generated by 🚫 Danger Swift against 54c0638

@lmarceau lmarceau merged commit b9126ef into release/v139 May 12, 2025
10 checks passed
@lmarceau lmarceau deleted the mergify/bp/release/v139/pr-26584 branch May 12, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants