dts: msm8974: Add support for Nokia Lumia 930 #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -145,6 +145,7 @@ | |||
| - Samsung Galaxy S5 - SM-G900F | |||
| - Samsung Galaxy S5 China LTE (Duos) - SM-G9006V/W, SM-G9008V/W, SM-G9009W | |||
| - Sony Xperia Z3 - leo | |||
| - Nokia Lumia 930 - martini (quirky - see comment in `lk2nd/device/dts/msm8974/msm8974-nokia-martini.dts`) | |||
There was a problem hiding this comment.
...MNOPQRS...
TravMurav
reviewed
Mar 11, 2025
Comment on lines
+6
to
+9
| //this is the cmd used to compile lk1st for Lumia930 | ||
| // make TOOLCHAIN_PREFIX=arm-none-eabi- DEBUG=1 DEBUG_FBCON=0 LK2ND_BUNDLE_DTB=msm8974-nokia-martini.dtb lk1st-msm8974 | ||
| //CAUTION: this device is quirky cause its a Windows phone, it needs cat build-lk1st-msm8974/lk_s.elf build-lk1st-msm8974/lk2nd/device/dts/msm8974-nokia-martini.dtb > emmc_appsboot.mbn | ||
| //The panel does not work if lk2nds const-splash is disabled which is the case on lk1st so dont expect display support |
There was a problem hiding this comment.
I'd prefer this to be C style comment (/* */) and folded to 80-100 where it makes sense.
| //The panel does not work if lk2nds const-splash is disabled which is the case on lk1st so dont expect display support | ||
|
|
||
| / { | ||
| qcom,msm-id = <QCOM_ID_MSM8974 0x96 0x20002 0xb>; |
There was a problem hiding this comment.
Duplicated with msm8974-lge-hammerhead.dts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.