Return both permission level and label from user permissions endpoint #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the function of `get_user_permission_label`, to return a tuple of the permission level and label. This also renames the function to `get_user_permission_tuple`.
naglepuff
reviewed
Aug 23, 2021
naglepuff
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After seeing our use of #67 in multinet-app/multinet-client#192, I realized it's cumbersome to not return the integer permission level itself from the the API, as we'll just need to reconstruct it on the client anyway. This PR amends that to return both the level itself and the associated label, returning
nullfor both if they don't exist.I think this will make the use of it much easier on the client, in particular removing the need for code like this. @naglepuff lmk what you think.