fix : PHP8 json_decode() problem #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LittleXiaYuan I haven't had a chance to take a look at this yet, but I wanted to say thank you for the PR! :) Reviewing it is on my list! :) |
|
Thank you for your hard work. I am very happy to contribute PR to your project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, when I was running the test plugin, I unexpectedly encountered an error. The operating environment was PHP8.2, and then I checked the code
ConversationSerializer.php line 21,
The json_decode() function passed null, which will cause an error in the PHP8 version because the first parameter of json_decode() is required to be a string type, and passing null does not meet the requirements.