-
Notifications
You must be signed in to change notification settings - Fork 63
Add log_to_attrs decorator to scale function #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
97f344d
to
82b8f2a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #604 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 32
Lines 1784 1786 +2
=========================================
+ Hits 1784 1786 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I've requested a code review from @lochhh, but @hummuscience it would also be great to hear how this feature works for you. Basically, the arguments passed to the |
Note to self: this PR needs to be rebased and updated after #606 is merged, because of changes I'm making to the |
d2d17ea
to
05f490c
Compare
dc0e33f
to
9b08ab6
Compare
|
* added log_to_attrs decorator to scale function and documented its effects * adapted tests for the scale function * fixed mistakes in docstring formatting * use monospace consistently in docstring * updated docstring to follow new log style * adapt tests for the serialized attrs.log * more specific name for test helper function --------- Co-authored-by: Adam Tyson <[email protected]>
Description
What is this PR
Why is this PR needed?
Supersedes #553, see that PR (and the discussions below it) for a justification.
What does this PR do?
log_to_attrs
decorator (previously only used for filtering functions) to themovement.transforms.scale
functionscale
function's docstring (as notes and examples)References
#553
How has this PR been tested?
Existing test for the
scale
function were updated to check for the contents of log entries.Is this a breaking change?
No.
Does this PR require an update to the documentation?
The docstring has been expanded.
Checklist: